* [ras:rfc-mirror 2/2] mm/memblock.c:57:6: sparse: symbol 'memblock_have_mirror' was not declared. Should it be static?
@ 2015-02-04 1:58 kbuild test robot
2015-02-04 1:58 ` [PATCH ras] mirror: memblock_have_mirror can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-02-04 1:58 UTC (permalink / raw)
To: Tony Luck
Cc: kbuild-all, Andrew Morton, Linux Memory Management List,
Martin Schwidefsky, Catalin Marinas, Fabian Frederick,
Philipp Hachtmann, Emil Medve, Laura Abbott, Akinobu Mita
tree: git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git rfc-mirror
head: db3eb444d5eb1bbfe26891229eff520f523f2c47
commit: db3eb444d5eb1bbfe26891229eff520f523f2c47 [2/2] mirror: allocate boot time data structures from mirrored memory
reproduce:
# apt-get install sparse
git checkout db3eb444d5eb1bbfe26891229eff520f523f2c47
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> mm/memblock.c:57:6: sparse: symbol 'memblock_have_mirror' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH ras] mirror: memblock_have_mirror can be static
2015-02-04 1:58 [ras:rfc-mirror 2/2] mm/memblock.c:57:6: sparse: symbol 'memblock_have_mirror' was not declared. Should it be static? kbuild test robot
@ 2015-02-04 1:58 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-02-04 1:58 UTC (permalink / raw)
To: Tony Luck
Cc: kbuild-all, Andrew Morton, Linux Memory Management List,
Catalin Marinas, Martin Schwidefsky, Philipp Hachtmann,
Fabian Frederick, Xishi Qiu, Akinobu Mita, Emil Medve
mm/memblock.c:57:6: sparse: symbol 'memblock_have_mirror' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
memblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index 911ce52..8ea1dfc 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -54,7 +54,7 @@ int memblock_debug __initdata_memblock;
#ifdef CONFIG_MOVABLE_NODE
bool movable_node_enabled __initdata_memblock = false;
#endif
-bool memblock_have_mirror __initdata_memblock = false;
+static bool memblock_have_mirror __initdata_memblock = false;
static int memblock_can_resize __initdata_memblock;
static int memblock_memory_in_slab __initdata_memblock = 0;
static int memblock_reserved_in_slab __initdata_memblock = 0;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-04 1:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-04 1:58 [ras:rfc-mirror 2/2] mm/memblock.c:57:6: sparse: symbol 'memblock_have_mirror' was not declared. Should it be static? kbuild test robot
2015-02-04 1:58 ` [PATCH ras] mirror: memblock_have_mirror can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).