From: Oleg Nesterov <oleg@redhat.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Davidlohr Bueso <dave@stgolabs.net>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: fix lockdep build in rcu-protected get_mm_exe_file()
Date: Tue, 24 Mar 2015 20:02:29 +0100 [thread overview]
Message-ID: <20150324190229.GC11834@redhat.com> (raw)
In-Reply-To: <CALYGNiP15BLtxMmMnpEu94jZBtce7tCtJnavrguqFr1d2XxH_A@mail.gmail.com>
On 03/24, Konstantin Khlebnikov wrote:
>
> On Tue, Mar 24, 2015 at 9:10 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> >>>
> >>> "atomic_read(&mm->mm_users) <= 1" looks a bit more "safe". But again,
> >>> I won't insist.
> >>
> >> Not so safe: this will race with get_task_mm().
> >
> > How?
>
> I mean rcu/lockdep debug migh race with get_task_mm() and generate
> false-positive warning about non-protected rcu_dereference.
Still can't understand, I think it can't... and if it could, then this
warning would not be false positive.
Anut this doesn't matter because we seem to agree this check should go away.
> > Yeees, probably rcu_dereference_raw() would be even better. set_mm_exe_file()
> > must be called only if nobody but us can access this mm.
>
> Yep.
Great. Davidlohr will you agree?
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-24 19:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 14:47 [PATCH] mm: fix lockdep build in rcu-protected get_mm_exe_file() Konstantin Khlebnikov
2015-03-23 18:11 ` Davidlohr Bueso
2015-03-23 19:10 ` Oleg Nesterov
2015-03-24 14:38 ` Davidlohr Bueso
2015-03-24 17:13 ` Konstantin Khlebnikov
2015-03-24 18:10 ` Oleg Nesterov
2015-03-24 18:15 ` Konstantin Khlebnikov
2015-03-24 19:02 ` Oleg Nesterov [this message]
2015-03-25 1:30 ` [PATCH v2] prctl: avoid using mmap_sem for exe_file serialization Davidlohr Bueso
2015-03-25 9:21 ` Konstantin Khlebnikov
2015-03-25 10:42 ` [PATCH v3] " Davidlohr Bueso
2015-03-25 11:08 ` Konstantin Khlebnikov
2015-03-25 12:50 ` Davidlohr Bueso
2015-03-25 12:53 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324190229.GC11834@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=khlebnikov@yandex-team.ru \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).