[PATCH mmotm] set_page_huge_active() can be static

[PATCH mmotm] set_page_huge_active() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 hugetlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index b527a7a..e837e0b 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -937,13 +937,13 @@ bool page_huge_active(struct page *page)
 }
 
 /* never called for tail page */
-void set_page_huge_active(struct page *page)
+static void set_page_huge_active(struct page *page)
 {
 	VM_BUG_ON_PAGE(!PageHeadHuge(page), page);
 	SetPagePrivate(&page[1]);
 }
 
-void clear_page_huge_active(struct page *page)
+static void clear_page_huge_active(struct page *page)
 {
 	VM_BUG_ON_PAGE(!PageHeadHuge(page), page);
 	ClearPagePrivate(&page[1]);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[mmotm:master 223/507] mm/hugetlb.c:940:6: sparse: symbol 'set_page_huge_active' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   c226e49f30453de9c6d82b001a985254990b32e0
commit: 31e0965ee7e744862ba5d82b0e4d1dc04c947bd8 [223/507] mm-hugetlb-introduce-pagehugeactive-flag-fix
reproduce:
  # apt-get install sparse
  git checkout 31e0965ee7e744862ba5d82b0e4d1dc04c947bd8
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   mm/hugetlb.c:933:6: sparse: symbol 'page_huge_active' was not declared. Should it be static?
>> mm/hugetlb.c:940:6: sparse: symbol 'set_page_huge_active' was not declared. Should it be static?
>> mm/hugetlb.c:946:6: sparse: symbol 'clear_page_huge_active' was not declared. Should it be static?
   mm/hugetlb.c:2071:20: sparse: symbol 'node_hstates' was not declared. Should it be static?
   mm/hugetlb.c:1327:20: sparse: context imbalance in 'gather_surplus_pages' - unexpected unlock
   mm/hugetlb.c:2950:9: sparse: context imbalance in 'hugetlb_cow' - unexpected unlock
   mm/hugetlb.c:3442:25: sparse: context imbalance in 'follow_hugetlb_page' - different lock contexts for basic block

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>