From: Andi Kleen <andi@firstfloor.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Linux-MM <linux-mm@kvack.org>, Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Dave Hansen <dave.hansen@intel.com>,
Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] mm: Send a single IPI to TLB flush multiple pages when unmapping
Date: Thu, 16 Apr 2015 00:20:06 +0200 [thread overview]
Message-ID: <20150415222006.GS2366@two.firstfloor.org> (raw)
In-Reply-To: <1429094576-5877-3-git-send-email-mgorman@suse.de>
I did a quick read and it looks good to me.
It's a bit ugly to bloat current with the ubc pointer,
but i guess there's no good way around that.
Also not nice to use GFP_ATOMIC for the allocation,
but again there's no way around it and it will
eventually recover if it fails. There may be
a slightly better GFP flag for this situation that
doesn't dip into the interrupt pools?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-04-15 22:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 10:42 [RFC PATCH 0/4] TLB flush multiple pages with a single IPI Mel Gorman
2015-04-15 10:42 ` [PATCH 1/4] x86, mm: Trace when an IPI is about to be sent Mel Gorman
2015-04-15 10:42 ` [PATCH 2/4] mm: Send a single IPI to TLB flush multiple pages when unmapping Mel Gorman
2015-04-15 21:03 ` Rik van Riel
2015-04-15 21:16 ` Hugh Dickins
2015-04-15 21:28 ` Mel Gorman
2015-04-15 21:32 ` Dave Hansen
2015-04-16 6:38 ` Minchan Kim
2015-04-16 8:07 ` Mel Gorman
2015-04-16 8:29 ` Minchan Kim
2015-04-16 9:19 ` Mel Gorman
2015-04-16 23:30 ` Minchan Kim
2015-04-15 22:20 ` Andi Kleen [this message]
2015-04-15 22:53 ` Mel Gorman
2015-04-15 10:42 ` [PATCH 3/4] mm: Gather more PFNs before sending a TLB to flush unmapped pages Mel Gorman
2015-04-15 11:42 ` Peter Zijlstra
2015-04-15 12:15 ` Mel Gorman
2015-04-15 12:24 ` Peter Zijlstra
2015-04-15 12:56 ` Mel Gorman
2015-04-15 10:42 ` [PATCH 4/4] mm: migrate: Batch TLB flushing when unmapping pages for migration Mel Gorman
2015-04-15 21:06 ` Hugh Dickins
2015-04-15 21:44 ` Mel Gorman
2015-04-15 23:50 ` Hugh Dickins
-- strict thread matches above, loose matches on Subject: below --
2015-04-16 10:22 [RFC PATCH 0/4] TLB flush multiple pages with a single IPI v2 Mel Gorman
2015-04-16 10:22 ` [PATCH 2/4] mm: Send a single IPI to TLB flush multiple pages when unmapping Mel Gorman
2015-04-16 15:52 ` Rik van Riel
2015-04-16 19:21 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415222006.GS2366@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).