From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Vladimir Davydov <vdavydov@parallels.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Greg Thelen <gthelen@google.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] gfp: add __GFP_NOACCOUNT
Date: Wed, 6 May 2015 09:16:22 -0400 [thread overview]
Message-ID: <20150506131622.GA4629@cmpxchg.org> (raw)
In-Reply-To: <20150506115941.GH14550@dhcp22.suse.cz>
On Wed, May 06, 2015 at 01:59:41PM +0200, Michal Hocko wrote:
> On Tue 05-05-15 12:45:42, Vladimir Davydov wrote:
> > Not all kmem allocations should be accounted to memcg. The following
> > patch gives an example when accounting of a certain type of allocations
> > to memcg can effectively result in a memory leak.
>
> > This patch adds the __GFP_NOACCOUNT flag which if passed to kmalloc
> > and friends will force the allocation to go through the root
> > cgroup. It will be used by the next patch.
>
> The name of the flag is way too generic. It is not clear that the
> accounting is KMEMCG related.
The memory controller is the (primary) component that accounts
physical memory allocations in the kernel, so I don't see how this
would be ambiguous in any way.
> __GFP_NO_KMEMCG sounds better?
I think that's much worse. I would prefer communicating the desired
behavior directly instead of having to derive it from a subsystem
name.
(And KMEMCG should not even be a term, it's all just the memory
controller, i.e. memcg.)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-06 13:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 9:45 [PATCH 1/2] gfp: add __GFP_NOACCOUNT Vladimir Davydov
2015-05-05 9:45 ` [PATCH 2/2] kernfs: do not account ino_ida allocations to memcg Vladimir Davydov
2015-05-05 13:45 ` Tejun Heo
2015-05-05 16:04 ` Vladimir Davydov
2015-05-06 11:59 ` [PATCH 1/2] gfp: add __GFP_NOACCOUNT Michal Hocko
2015-05-06 12:24 ` Vladimir Davydov
2015-05-06 12:35 ` Michal Hocko
2015-05-06 13:25 ` Vladimir Davydov
2015-05-06 13:55 ` Michal Hocko
2015-05-06 14:29 ` Vladimir Davydov
2015-05-06 14:46 ` Michal Hocko
2015-05-06 13:16 ` Johannes Weiner [this message]
2015-05-06 13:46 ` Michal Hocko
2015-05-06 15:00 ` Johannes Weiner
2015-05-06 14:58 ` Michal Hocko
2015-05-06 16:35 ` [PATCH v2] " Vladimir Davydov
2015-05-06 17:52 ` [PATCH 1/2] " Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506131622.GA4629@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=gthelen@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).