From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com [209.85.223.182]) by kanga.kvack.org (Postfix) with ESMTP id 288C36B0070 for ; Mon, 11 May 2015 10:41:15 -0400 (EDT) Received: by iedfl3 with SMTP id fl3so122936341ied.1 for ; Mon, 11 May 2015 07:41:15 -0700 (PDT) Received: from mail.kernel.org (mail.kernel.org. [198.145.29.136]) by mx.google.com with ESMTP id j15si9880255ich.52.2015.05.11.07.41.14 for ; Mon, 11 May 2015 07:41:14 -0700 (PDT) Date: Mon, 11 May 2015 11:41:10 -0300 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH 4/6] perf kmem: Print gfp flags in human readable string Message-ID: <20150511144110.GR28183@kernel.org> References: <1429592107-1807-1-git-send-email-namhyung@kernel.org> <1429592107-1807-5-git-send-email-namhyung@kernel.org> <20150511143536.GP28183@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150511143536.GP28183@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Joonsoo Kim , Minchan Kim , Pekka Enberg , linux-mm@kvack.org Em Mon, May 11, 2015 at 11:35:36AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 21, 2015 at 01:55:05PM +0900, Namhyung Kim escreveu: > > Save libtraceevent output and print it in the header. > > > > > +static int parse_gfp_flags(struct perf_evsel *evsel, struct perf_sample *sample, > > + unsigned int gfp_flags) > > +{ > > + char *str, *pos; > > + str = strtok_r(seq.buffer, " ", &pos); > > builtin-kmem.c:743:427: error: a??posa?? may be used uninitialized in this > function [-Werror=maybe-uninitialized] > new->human_readable = strdup(str + 10); > ^ > builtin-kmem.c:716:14: note: a??posa?? was declared here > char *str, *pos; > ^ Emphasis on the "may", as according to strtok_r your code is ok, its just the compiler that needs to be told that no, it is not being accessed uninitialized: On the first call to strtok_r(), str should point to the string to be parsed, and the value of saveptr is ignored. In subsequent calls, str should be NULL, and saveptr should be unchanged since the previous call. So just setting it to NULL is enough. - Arnaldo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org