From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 120/255] include/asm-generic/pgtable.h:206:2: warning: (near initialization for '(anonymous).pmd')
Date: Thu, 14 May 2015 12:52:28 -0700 [thread overview]
Message-ID: <20150514125228.4acd45b5576d7109de10fe17@linux-foundation.org> (raw)
In-Reply-To: <201505141007.XJqGCdko%fengguang.wu@intel.com>
On Thu, 14 May 2015 10:20:08 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: e55a38145ac0946f090895afc5c8ba0717790908
> commit: add8ee4dd125729fb48d5cc73b194f28f1a6eccb [120/255] mm/thp: split out pmd collapse/flush into separate functions
> config: m68k-multi_defconfig (attached as .config)
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout add8ee4dd125729fb48d5cc73b194f28f1a6eccb
> # save the attached .config to linux build tree
> make.cross ARCH=m68k
>
> All warnings:
>
> In file included from arch/m68k/include/asm/pgtable_mm.h:172:0,
> from arch/m68k/include/asm/pgtable.h:4,
> from include/linux/mm.h:53,
> from include/linux/scatterlist.h:6,
> from include/linux/dmaengine.h:24,
> from include/linux/netdevice.h:38,
> from net/batman-adv/main.h:168,
> from net/batman-adv/bat_iv_ogm.c:18:
> include/asm-generic/pgtable.h: In function 'pmdp_collapse_flush':
> include/asm-generic/pgtable.h:206:2: warning: missing braces around initializer [-Wmissing-braces]
> return __pmd(0);
hm, yes, there is no requirement for the architecture to implement
__pmd() and it shouldn't be used in include/linux.
Will this work?
--- a/include/asm-generic/pgtable.h~mm-thp-split-out-pmd-collpase-flush-into-a-separate-functions-fix-2
+++ a/include/asm-generic/pgtable.h
@@ -203,7 +203,7 @@ static inline pmd_t pmdp_collapse_flush(
pmd_t *pmdp)
{
BUILD_BUG();
- return __pmd(0);
+ return *pmdp;
}
#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
#endif
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-05-14 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 2:20 [mmotm:master 120/255] include/asm-generic/pgtable.h:206:2: warning: (near initialization for '(anonymous).pmd') kbuild test robot
2015-05-14 19:52 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514125228.4acd45b5576d7109de10fe17@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).