Re: [PATCH] zram: check compressor name before setting it

Sergey Senozhatsky
2015-05-22T12:43:51Z

On (05/22/15 11:12), Marcin Jabrzyk wrote:
> >
> >no.
> >
> >zram already complains about failed comp backend creation.
> >it's in dmesg (or syslog, etc.):
> >
> > "zram: Cannot initialise %s compressing backend"
> >
> OK, now I see that. Sorry for the noise.
>
> >second, there is not much value in exposing zcomp internals,
> >especially when the result is just another line in dmesg output.
>
> From the other hand, the only valid values that can be written are
> in 'comp_algorithm'.
> So when writing other one, returning -EINVAL seems to be reasonable.
> The user would get immediately information that he can't do that,
> now the information can be very deferred in time.

it's not.
the error message appears in syslog right before we return -EINVAL
back to user.

-ss

> I'm not for exposing more internals, but getting -EINVAL would be nice I