From: Andrew Morton <akpm@linux-foundation.org>
To: Dan Streetman <ddstreet@ieee.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Minchan Kim <minchan@kernel.org>,
Ganesh Mahendran <opensource.ganesh@gmail.com>,
Kees Cook <keescook@chromium.org>, Linux-MM <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] zpool: add EXPORT_SYMBOL for functions
Date: Fri, 29 May 2015 14:37:20 -0700 [thread overview]
Message-ID: <20150529143720.f660ab8a16aefa816da04a0a@linux-foundation.org> (raw)
In-Reply-To: <CALZtONAWMk1L9r1NRr3FiW-2T020EL7Q5HAt-zwt8D43TfNewg@mail.gmail.com>
On Fri, 29 May 2015 12:35:46 -0400 Dan Streetman <ddstreet@ieee.org> wrote:
> On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
> >> because they are available for public use, per zpool.h? If, e.g.,
> >> zram ever started using zpool, it would need them exported, wouldn't
> >> it?
> >
> > If you want to use it in ram export it in the same series as those
> > changes, and explain what the exprots are for in your message body.
> >
>
> I don't want to use it in zram. I wrote zpool, but neglected to
> export the functions. They should be exported though.
>
> What's your reasoning for not wanting them exported?
It's just noise which has no value. Adding exports when there is a
demonstrated need is an OK approach.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-05-29 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 15:09 [PATCH] zpool: add EXPORT_SYMBOL for functions Dan Streetman
2015-05-29 15:22 ` Christoph Hellwig
2015-05-29 15:36 ` Dan Streetman
2015-05-29 16:30 ` Christoph Hellwig
2015-05-29 16:35 ` Dan Streetman
2015-05-29 21:37 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529143720.f660ab8a16aefa816da04a0a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=opensource.ganesh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).