From: Andrew Morton <akpm@linux-foundation.org>
To: Dominik Dingel <dingel@linux.vnet.ibm.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [next:master 7235/7555] mm/page_alloc.c:654:121: warning: comparison of distinct pointer types lacks a cast
Date: Mon, 1 Jun 2015 14:11:09 -0700 [thread overview]
Message-ID: <20150601141109.19f65bd0f4e667783fa5ca7c@linux-foundation.org> (raw)
In-Reply-To: <20150531121815.254f9bc2@BR9TG4T3.de.ibm.com>
On Sun, 31 May 2015 12:18:15 +0200 Dominik Dingel <dingel@linux.vnet.ibm.com> wrote:
> > And on s390, HPAGE_SHIFT is unsigned int. On x86 HPAGE_SHIFT has type
> > int. I suggest the fix here is to make s390's HPAGE_SHIFT have type
> > int as well.
>
> Thanks for noticing. As my way to handle this was mostly inspired by the
> way powerpc does it, I'm kind of puzzled why they don't have the same problem?
>
> So I checked and your fix seems to be the right thing to do. But then I would
> assume the powerpc type for HPAGE should also be changed?
powerpc sets CONFIG_HUGETLB_PAGE_SIZE_VARIABLE so it uses
extern int pageblock_order;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-06-01 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 17:48 [next:master 7235/7555] mm/page_alloc.c:654:121: warning: comparison of distinct pointer types lacks a cast kbuild test robot
2015-05-29 20:32 ` Andrew Morton
2015-05-31 10:18 ` Dominik Dingel
2015-06-01 21:11 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601141109.19f65bd0f4e667783fa5ca7c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dingel@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).