linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: josh@joshtriplett.org
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: include/linux/bug.h:93:12: error: dereferencing pointer to incomplete type
Date: Mon, 1 Jun 2015 16:27:55 -0700	[thread overview]
Message-ID: <20150601232755.GA30913@cloud> (raw)
In-Reply-To: <201506020621.UtqnXSMY%fengguang.wu@intel.com>

On Tue, Jun 02, 2015 at 06:08:25AM +0800, kbuild test robot wrote:
> All error/warnings:
> 
>    In file included from include/linux/page-flags.h:9:0,
>                     from kernel/bounds.c:9:
> >> include/linux/bug.h:91:47: warning: 'struct bug_entry' declared inside parameter list
>     static inline int is_warning_bug(const struct bug_entry *bug)
>                                                   ^
> >> include/linux/bug.h:91:47: warning: its scope is only this definition or declaration, which is probably not what you want
>    include/linux/bug.h: In function 'is_warning_bug':
> >> include/linux/bug.h:93:12: error: dereferencing pointer to incomplete type
>      return bug->flags & BUGFLAG_WARNING;
>                ^
>    make[2]: *** [kernel/bounds.s] Error 1
>    make[2]: Target '__build' not remade because of errors.
>    make[1]: *** [prepare0] Error 2
>    make[1]: Target 'prepare' not remade because of errors.
>    make: *** [sub-make] Error 2
> 
> vim +93 include/linux/bug.h
> 
> 35edd910 Paul Gortmaker      2011-11-16  85  
> 35edd910 Paul Gortmaker      2011-11-16  86  #endif	/* __CHECKER__ */
> 35edd910 Paul Gortmaker      2011-11-16  87  
> 7664c5a1 Jeremy Fitzhardinge 2006-12-08  88  #ifdef CONFIG_GENERIC_BUG
> 7664c5a1 Jeremy Fitzhardinge 2006-12-08  89  #include <asm-generic/bug.h>
> 7664c5a1 Jeremy Fitzhardinge 2006-12-08  90  
> 7664c5a1 Jeremy Fitzhardinge 2006-12-08 @91  static inline int is_warning_bug(const struct bug_entry *bug)
> 7664c5a1 Jeremy Fitzhardinge 2006-12-08  92  {
> 7664c5a1 Jeremy Fitzhardinge 2006-12-08 @93  	return bug->flags & BUGFLAG_WARNING;
> 7664c5a1 Jeremy Fitzhardinge 2006-12-08  94  }
> 7664c5a1 Jeremy Fitzhardinge 2006-12-08  95  
> 7664c5a1 Jeremy Fitzhardinge 2006-12-08  96  const struct bug_entry *find_bug(unsigned long bugaddr);

This looks like a bug in mn10300.  This code is within an ifdef on
CONFIG_GENERIC_BUG, and the declaration of the structure is within
ifdefs on both CONFIG_GENERIC_BUG and CONFIG_BUG, but:

> CONFIG_MN10300=y
[...]
> CONFIG_GENERIC_BUG=y
[...]
> # CONFIG_BUG is not set

Other architectures, including x86 (arch/x86/Kconfig) and powerpc
(arch/powerpc/Kconfig) have GENERIC_BUG depend on BUG.  Looks like
mn10300 doesn't.

- Josh Triplett

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-06-01 23:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 22:08 include/linux/bug.h:93:12: error: dereferencing pointer to incomplete type kbuild test robot
2015-06-01 23:27 ` josh [this message]
2015-06-02  2:27   ` Fengguang Wu
  -- strict thread matches above, loose matches on Subject: below --
2015-07-04 12:36 kbuild test robot
2015-07-04 20:48 ` Josh Triplett
2015-07-05  1:21   ` Fengguang Wu
2016-02-28 23:33 kbuild test robot
2016-02-29 20:49 ` Andrew Morton
2016-02-29 21:24   ` Josh Triplett
2016-03-06 22:08 kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150601232755.GA30913@cloud \
    --to=josh@joshtriplett.org \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).