From: Tejun Heo <tj@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-mm@kvack.org
Subject: Re: writeback: implement memcg wb_domain
Date: Fri, 5 Jun 2015 06:13:51 +0900 [thread overview]
Message-ID: <20150604211351.GU20091@mtj.duckdns.org> (raw)
In-Reply-To: <20150604105738.GA7070@mwanda>
On Thu, Jun 04, 2015 at 01:57:38PM +0300, Dan Carpenter wrote:
> Hello Tejun Heo,
>
> The patch 841710aa6e4a: "writeback: implement memcg wb_domain" from
> May 22, 2015, leads to the following static checker warning:
>
> mm/backing-dev.c:558 cgwb_create()
> warn: missing error code here? 'wb_congested_get_create()' failed. 'ret' = '0'
>
> mm/backing-dev.c
> 548 ret = percpu_ref_init(&wb->refcnt, cgwb_release, 0, gfp);
> 549 if (ret)
> 550 goto err_wb_exit;
> 551
> 552 ret = fprop_local_init_percpu(&wb->memcg_completions, gfp);
> 553 if (ret)
> 554 goto err_ref_exit;
> 555
> 556 wb->congested = wb_congested_get_create(bdi, blkcg_css->id, gfp);
> 557 if (!wb->congested)
> 558 goto err_fprop_exit;
> ^^^^^^^^^^^^^^^^^^^
> Did you want to set ret = -ENOMEM here?
Yes, definitely. Thank you very much for spotting it. Will send a
fix patch soon.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-06-04 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 10:57 writeback: implement memcg wb_domain Dan Carpenter
2015-06-04 21:13 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604211351.GU20091@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).