From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Christoph Lameter <cl@linux.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
linux-mm@kvack.org, netdev@vger.kernel.org, brouer@redhat.com
Subject: Re: [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT
Date: Mon, 8 Jun 2015 11:23:59 +0200 [thread overview]
Message-ID: <20150608112359.04a3750e@redhat.com> (raw)
In-Reply-To: <1433471877.1895.51.camel@edumazet-glaptop2.roam.corp.google.com>
On Thu, 04 Jun 2015 19:37:57 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Thu, 2015-06-04 at 12:31 +0200, Jesper Dangaard Brouer wrote:
> > This patch improves performance of SLUB allocator fastpath with 38% by
> > avoiding the call to this_cpu_cmpxchg_double() for NO-PREEMPT kernels.
> >
> > Reviewers please point out why this change is wrong, as such a large
> > improvement should not be possible ;-)
>
> I am not sure if anyone already answered, but the cmpxchg_double()
> is needed to avoid the ABA problem.
>
> This is the whole point using tid _and_ freelist
>
> Preemption is not the only thing that could happen here, think of
> interrupts.
Yes, I sort of already knew this.
My real question is if disabling local interrupts is enough to avoid this?
And, does local irq disabling also stop preemption?
Questions relate to this patch:
http://ozlabs.org/~akpm/mmots/broken-out/slub-bulk-alloc-extract-objects-from-the-per-cpu-slab.patch
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-08 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 10:31 [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT Jesper Dangaard Brouer
2015-06-05 2:37 ` Eric Dumazet
2015-06-08 9:23 ` Jesper Dangaard Brouer [this message]
2015-06-08 9:39 ` Christoph Lameter
2015-06-08 9:58 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608112359.04a3750e@redhat.com \
--to=brouer@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).