Re: [RFC NEXT] mm: Fix suspicious RCU usage at kernel/sched/core.c:7318

Martin KaFai Lau
2015-06-17T04:15:36Z

On Tue, Jun 16, 2015 at 09:43:28PM -0500, Larry Finger wrote:
> On 06/16/2015 04:07 PM, Martin KaFai Lau wrote:
> >On Mon, Jun 15, 2015 at 04:25:18PM -0500, Larry Finger wrote:
> >>Additional backtrace lines are truncated. In addition, the above splat is
> >>followed by several "BUG: sleeping function called from invalid context
> >>at mm/slub.c:1268" outputs. As suggested by Martin KaFai Lau, these are the
> >>clue to the fix. Routine kmemleak_alloc_percpu() always uses GFP_KERNEL
> >>for its allocations, whereas it should use the value input to pcpu_alloc().
> >Just a minor nit, 'kmemleak_alloc_percpu() should follow the gfp from
> >per_alloc()' may be a more accurate title to describe the patch.
>
> Do you mean that the subject should be changed?
Yes

A typo in my last response: s/per_alloc/pcpu_alloc/

--Martin