linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [RFC][PATCHv3 2/7] zsmalloc: partial page ordering within a fullness_list
Date: Thu, 18 Jun 2015 23:43:43 +0900	[thread overview]
Message-ID: <20150618144343.GA12441@swordfish> (raw)
In-Reply-To: <20150618121314.GA518@swordfish>

On (06/18/15 21:13), Sergey Senozhatsky wrote:
> @@ -645,10 +645,11 @@ static void insert_zspage(struct page *page, struct size_class *class,
>  		 * We want to see more ZS_FULL pages and less almost
>  		 * empty/full. Put pages with higher ->inuse first.
>  		 */
> -		if (page->inuse < (*head)->inuse)
> -			list_add_tail(&page->lru, &(*head)->lru);
> -		else
> +		if (fullness == ZS_ALMOST_FULL ||
> +				(page->inuse >= (*head)->inuse))
>  			list_add(&page->lru, &(*head)->lru);
> +		else
> +			list_add_tail(&page->lru, &(*head)->lru);
>  	}
>  
>  	*head = page;

oh, dear. what I was thinking of. this is just stupid. please ignore
this part.

	-ss

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-06-18 14:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 11:46 [RFC][PATCH v3 0/7] introduce automatic pool compaction Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 1/7] zsmalloc: drop unused variable `nr_to_migrate' Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 2/7] zsmalloc: partial page ordering within a fullness_list Sergey Senozhatsky
2015-06-18 12:13   ` Sergey Senozhatsky
2015-06-18 12:45     ` Sergey Senozhatsky
2015-06-18 12:48     ` Sergey Senozhatsky
2015-06-18 14:43     ` Sergey Senozhatsky [this message]
2015-06-29  6:52   ` Minchan Kim
2015-06-29 23:41     ` Sergey Senozhatsky
2015-06-30  0:42       ` Minchan Kim
2015-06-18 11:46 ` [RFC][PATCHv3 3/7] zsmalloc: always keep per-class stats Sergey Senozhatsky
2015-06-29  6:40   ` Minchan Kim
2015-06-29  9:06     ` Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 4/7] zsmalloc: introduce zs_can_compact() function Sergey Senozhatsky
2015-06-29  6:45   ` Minchan Kim
2015-06-29  8:58     ` Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 5/7] zsmalloc: cosmetic compaction code adjustments Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 6/7] zsmalloc/zram: move `num_migrated' to zs_pool Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 7/7] zsmalloc: register a shrinker to trigger auto-compaction Sergey Senozhatsky
2015-06-29  7:07   ` Minchan Kim
2015-06-29  8:57     ` Sergey Senozhatsky
2015-06-29 13:39       ` Minchan Kim
2015-06-29 23:36         ` Sergey Senozhatsky
2015-06-18 12:17 ` [RFC][PATCH v3 0/7] introduce automatic pool compaction Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150618144343.GA12441@swordfish \
    --to=sergey.senozhatsky@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).