From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 1/3] mm, oom: organize oom context into struct
Date: Fri, 19 Jun 2015 09:14:23 +0900 [thread overview]
Message-ID: <20150619001423.GA5628@swordfish> (raw)
In-Reply-To: <alpine.DEB.2.10.1506181555350.13736@chino.kir.corp.google.com>
Hello,
On (06/18/15 16:00), David Rientjes wrote:
> There are essential elements to an oom context that are passed around to
> multiple functions.
>
> Organize these elements into a new struct, struct oom_context, that
> specifies the context for an oom condition.
>
s/oom_context/oom_control/ ?
[..]
>
> +struct oom_control {
> + struct zonelist *zonelist;
> + nodemask_t *nodemask;
> + gfp_t gfp_mask;
> + int order;
> + bool force_kill;
> +};
> +
> -extern void check_panic_on_oom(enum oom_constraint constraint, gfp_t gfp_mask,
> - int order, const nodemask_t *nodemask,
> +extern void check_panic_on_oom(struct oom_control *oc,
> + enum oom_constraint constraint,
> struct mem_cgroup *memcg);
>
> -extern enum oom_scan_t oom_scan_process_thread(struct task_struct *task,
> - unsigned long totalpages, const nodemask_t *nodemask,
> - bool force_kill);
> +extern enum oom_scan_t oom_scan_process_thread(struct oom_control *oc,
> + struct task_struct *task, unsigned long totalpages);
>
> -extern bool out_of_memory(struct zonelist *zonelist, gfp_t gfp_mask,
> - int order, nodemask_t *mask, bool force_kill);
> +extern bool out_of_memory(struct oom_control *oc);
>
> extern void exit_oom_victim(void);
>
[..]
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-19 0:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 23:00 [patch 1/3] mm, oom: organize oom context into struct David Rientjes
2015-06-18 23:00 ` [patch 2/3] mm, oom: pass an oom order of -1 when triggered by sysrq David Rientjes
2015-06-19 7:32 ` Michal Hocko
2015-06-30 22:50 ` David Rientjes
2015-06-18 23:00 ` [patch 3/3] mm, oom: do not panic for oom kills triggered from sysrq David Rientjes
2015-06-19 0:14 ` Sergey Senozhatsky [this message]
2015-06-30 22:46 ` [patch 1/3] mm, oom: organize oom context into struct David Rientjes
2015-07-01 0:11 ` Sergey Senozhatsky
2015-07-01 21:29 ` David Rientjes
2015-06-19 7:30 ` Michal Hocko
2015-07-01 21:37 ` [patch v2 " David Rientjes
2015-07-01 21:37 ` [patch v2 2/3] " David Rientjes
2015-07-02 6:01 ` Michal Hocko
2015-07-08 23:28 ` David Rientjes
2015-07-01 21:37 ` [patch v2 3/3] " David Rientjes
2015-07-02 6:00 ` [patch v2 1/3] " Michal Hocko
2015-07-08 23:42 ` [patch v3 " David Rientjes
2015-07-08 23:42 ` [patch v3 2/3] mm, oom: pass an oom order of -1 when triggered by sysrq David Rientjes
2015-07-08 23:42 ` [patch v3 3/3] mm, oom: do not panic for oom kills triggered from sysrq David Rientjes
2015-07-14 22:52 ` [patch v3 1/3] mm, oom: organize oom context into struct Andrew Morton
2015-07-14 23:44 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619001423.GA5628@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).