From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by kanga.kvack.org (Postfix) with ESMTP id 98A1D6B0032 for ; Mon, 29 Jun 2015 19:40:57 -0400 (EDT) Received: by pdbep18 with SMTP id ep18so102886226pdb.1 for ; Mon, 29 Jun 2015 16:40:57 -0700 (PDT) Received: from mail-pa0-x22b.google.com (mail-pa0-x22b.google.com. [2607:f8b0:400e:c03::22b]) by mx.google.com with ESMTPS id a5si66785265pat.91.2015.06.29.16.40.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 16:40:56 -0700 (PDT) Received: by padev16 with SMTP id ev16so112601190pad.0 for ; Mon, 29 Jun 2015 16:40:56 -0700 (PDT) Date: Tue, 30 Jun 2015 08:41:24 +0900 From: Sergey Senozhatsky Subject: Re: [RFC][PATCHv3 2/7] zsmalloc: partial page ordering within a fullness_list Message-ID: <20150629234124.GB7301@swordfish> References: <1434628004-11144-1-git-send-email-sergey.senozhatsky@gmail.com> <1434628004-11144-3-git-send-email-sergey.senozhatsky@gmail.com> <20150629065218.GC13179@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150629065218.GC13179@bbox> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Hello, Sorry for long reply. On (06/29/15 15:52), Minchan Kim wrote: [..] > > head = &class->fullness_list[fullness]; > > - if (*head) > > - list_add_tail(&page->lru, &(*head)->lru); > > + if (*head) { > > + /* > > + * We want to see more ZS_FULL pages and less almost > > + * empty/full. Put pages with higher ->inuse first. > > + */ > > + if (page->inuse < (*head)->inuse) > > + list_add_tail(&page->lru, &(*head)->lru); > > + else > > + list_add(&page->lru, &(*head)->lru); > > + } > > > > > *head = page; > > Why do you want to always put @page in the head? > How about this? Yeah, right. Looks OK to me. How do we want to handle it? Do you want to submit it with Suggested-by: ss (I'm fine) or you want me to submit it later today with Suggested-by: Minchan Kim? -ss > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index e8cb31c..1c5fde9 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -658,21 +658,25 @@ static void insert_zspage(struct page *page, struct size_class *class, > if (fullness >= _ZS_NR_FULLNESS_GROUPS) > return; > > + zs_stat_inc(class, fullness == ZS_ALMOST_EMPTY ? > + CLASS_ALMOST_EMPTY : CLASS_ALMOST_FULL, 1); > + > head = &class->fullness_list[fullness]; > - if (*head) { > - /* > - * We want to see more ZS_FULL pages and less almost > - * empty/full. Put pages with higher ->inuse first. > - */ > - if (page->inuse < (*head)->inuse) > - list_add_tail(&page->lru, &(*head)->lru); > - else > - list_add(&page->lru, &(*head)->lru); > + if (!*head) { > + *head = page; > + return; > } > > - *head = page; > - zs_stat_inc(class, fullness == ZS_ALMOST_EMPTY ? > - CLASS_ALMOST_EMPTY : CLASS_ALMOST_FULL, 1); > + /* > + * We want to see more ZS_FULL pages and less almost > + * empty/full. Put pages with higher ->inuse first. > + */ > + list_add_tail(&page->lru, &(*head)->lru); > + if (page->inuse >= (*head)->inuse) > + *head = page; > } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org