From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: David Rientjes <rientjes@google.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/11] mm: debug: dump page into a string rather than directly on screen
Date: Wed, 1 Jul 2015 11:53:04 +0300 [thread overview]
Message-ID: <20150701085304.GA18268@node.dhcp.inet.fi> (raw)
In-Reply-To: <alpine.DEB.2.10.1506301627030.5359@chino.kir.corp.google.com>
On Tue, Jun 30, 2015 at 04:35:45PM -0700, David Rientjes wrote:
> I do understand the problem with the current VM_BUG_ON_PAGE() and
> VM_BUG_ON_VMA() stuff, and it compels me to ask about just going back to
> the normal
>
> VM_BUG_ON(cond);
>
> coupled with dump_page(), dump_vma(), dump_whatever(). It all seems so
> much simpler to me.
Is there a sensible way to couple them? I don't see much, except opencode
VM_BUG_ON():
if (IS_ENABLED(CONFIG_DEBUG_VM) && cond) {
dump_page(...);
dump_vma(...);
dump_whatever();
BUG();
}
That's too verbose to me to be usable.
BTW, I also tried[1] to solve this problem too, but people doesn't like
either.
[1] http://lkml.kernel.org/g/1412163121-4295-1-git-send-email-kirill.shutemov@linux.intel.com
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-01 8:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 17:10 [PATCH 00/11] mm: debug: formatting memory management structs Sasha Levin
2015-05-14 17:10 ` [PATCH 01/11] mm: debug: format flags in a buffer Sasha Levin
2015-05-14 17:10 ` [PATCH 02/11] mm: debug: deal with a new family of MM pointers Sasha Levin
2015-05-14 17:10 ` [PATCH 03/11] mm: debug: dump VMA into a string rather than directly on screen Sasha Levin
2015-05-14 17:10 ` [PATCH 04/11] mm: debug: dump struct MM " Sasha Levin
2015-05-14 17:10 ` [PATCH 05/11] mm: debug: dump page " Sasha Levin
2015-06-30 23:35 ` David Rientjes
2015-07-01 8:53 ` Kirill A. Shutemov [this message]
2015-07-01 19:21 ` Sasha Levin
2015-07-01 21:25 ` David Rientjes
2015-07-01 21:34 ` Kirill A. Shutemov
2015-07-01 22:33 ` Vlastimil Babka
2015-07-01 22:50 ` Sasha Levin
2015-07-08 23:58 ` David Rientjes
2015-08-06 15:08 ` Sasha Levin
2015-05-14 17:10 ` [PATCH 06/11] mm: debug: clean unused code Sasha Levin
2015-05-14 17:10 ` [PATCH 07/11] mm: debug: VM_BUG() Sasha Levin
2015-05-14 17:10 ` [PATCH 08/11] mm: debug: kill VM_BUG_ON_PAGE Sasha Levin
2015-05-14 17:10 ` [PATCH 09/11] mm: debug: kill VM_BUG_ON_VMA Sasha Levin
2015-05-14 17:10 ` [PATCH 10/11] mm: debug: kill VM_BUG_ON_MM Sasha Levin
2015-05-14 17:10 ` [PATCH 11/11] mm: debug: use VM_BUG() to help with debug output Sasha Levin
2015-05-14 20:24 ` [PATCH 00/11] mm: debug: formatting memory management structs Andrew Morton
2015-05-14 20:26 ` Sasha Levin
2015-06-26 21:34 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701085304.GA18268@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).