* [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range()
@ 2015-07-01 18:30 Aristeu Rozanski
2015-07-01 18:45 ` Kirill A. Shutemov
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Aristeu Rozanski @ 2015-07-01 18:30 UTC (permalink / raw)
To: Naoya Horiguchi
Cc: Kirill A. Shutemov, Andrea Arcangeli, Cyrill Gorcunov,
Dave Hansen, Pavel Emelyanov, Benjamin Herrenschmidt, linux-mm
This check was introduced as part of
6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
which got duplicated by
48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
by reintroducing it earlier on queue_page_test_walk()
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Aristeu Rozanski <aris@redhat.com>
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 99d4c1d..9885d07 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -608,9 +608,6 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
qp->prev = vma;
- if (vma->vm_flags & VM_PFNMAP)
- return 1;
-
if (flags & MPOL_MF_LAZY) {
/* Similar to task_numa_work, skip inaccessible VMAs */
if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range()
2015-07-01 18:30 [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range() Aristeu Rozanski
@ 2015-07-01 18:45 ` Kirill A. Shutemov
2015-07-01 20:15 ` Cyrill Gorcunov
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Kirill A. Shutemov @ 2015-07-01 18:45 UTC (permalink / raw)
To: Aristeu Rozanski
Cc: Naoya Horiguchi, Kirill A. Shutemov, Andrea Arcangeli,
Cyrill Gorcunov, Dave Hansen, Pavel Emelyanov,
Benjamin Herrenschmidt, linux-mm
On Wed, Jul 01, 2015 at 02:30:58PM -0400, Aristeu Rozanski wrote:
> This check was introduced as part of
> 6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
> which got duplicated by
> 48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
> by reintroducing it earlier on queue_page_test_walk()
>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: Dave Hansen <dave.hansen@intel.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Pavel Emelyanov <xemul@parallels.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range()
2015-07-01 18:30 [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range() Aristeu Rozanski
2015-07-01 18:45 ` Kirill A. Shutemov
@ 2015-07-01 20:15 ` Cyrill Gorcunov
2015-07-01 23:18 ` Naoya Horiguchi
2015-07-09 0:58 ` David Rientjes
3 siblings, 0 replies; 5+ messages in thread
From: Cyrill Gorcunov @ 2015-07-01 20:15 UTC (permalink / raw)
To: Aristeu Rozanski
Cc: Naoya Horiguchi, Kirill A. Shutemov, Andrea Arcangeli,
Dave Hansen, Pavel Emelyanov, Benjamin Herrenschmidt, linux-mm
On Wed, Jul 01, 2015 at 02:30:58PM -0400, Aristeu Rozanski wrote:
> This check was introduced as part of
> 6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
> which got duplicated by
> 48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
> by reintroducing it earlier on queue_page_test_walk()
>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: Dave Hansen <dave.hansen@intel.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Pavel Emelyanov <xemul@parallels.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
Thank you!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range()
2015-07-01 18:30 [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range() Aristeu Rozanski
2015-07-01 18:45 ` Kirill A. Shutemov
2015-07-01 20:15 ` Cyrill Gorcunov
@ 2015-07-01 23:18 ` Naoya Horiguchi
2015-07-09 0:58 ` David Rientjes
3 siblings, 0 replies; 5+ messages in thread
From: Naoya Horiguchi @ 2015-07-01 23:18 UTC (permalink / raw)
To: Aristeu Rozanski
Cc: Kirill A. Shutemov, Andrea Arcangeli, Cyrill Gorcunov,
Dave Hansen, Pavel Emelyanov, Benjamin Herrenschmidt,
linux-mm@kvack.org
On Wed, Jul 01, 2015 at 02:30:58PM -0400, Aristeu Rozanski wrote:
> This check was introduced as part of
> 6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
> which got duplicated by
> 48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
> by reintroducing it earlier on queue_page_test_walk()
>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: Dave Hansen <dave.hansen@intel.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Pavel Emelyanov <xemul@parallels.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
Thank you for finding and fixing this.
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 99d4c1d..9885d07 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -608,9 +608,6 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
>
> qp->prev = vma;
>
> - if (vma->vm_flags & VM_PFNMAP)
> - return 1;
> -
> if (flags & MPOL_MF_LAZY) {
> /* Similar to task_numa_work, skip inaccessible VMAs */
> if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range()
2015-07-01 18:30 [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range() Aristeu Rozanski
` (2 preceding siblings ...)
2015-07-01 23:18 ` Naoya Horiguchi
@ 2015-07-09 0:58 ` David Rientjes
3 siblings, 0 replies; 5+ messages in thread
From: David Rientjes @ 2015-07-09 0:58 UTC (permalink / raw)
To: Aristeu Rozanski
Cc: Naoya Horiguchi, Kirill A. Shutemov, Andrea Arcangeli,
Cyrill Gorcunov, Dave Hansen, Pavel Emelyanov,
Benjamin Herrenschmidt, linux-mm
On Wed, 1 Jul 2015, Aristeu Rozanski wrote:
> This check was introduced as part of
> 6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
> which got duplicated by
> 48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
> by reintroducing it earlier on queue_page_test_walk()
>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: Dave Hansen <dave.hansen@intel.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Pavel Emelyanov <xemul@parallels.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-09 0:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 18:30 [PATCH] mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range() Aristeu Rozanski
2015-07-01 18:45 ` Kirill A. Shutemov
2015-07-01 20:15 ` Cyrill Gorcunov
2015-07-01 23:18 ` Naoya Horiguchi
2015-07-09 0:58 ` David Rientjes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).