From: Michal Hocko <mhocko@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jakob Unterwurzacher <jakobunt@gmail.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f
Date: Fri, 10 Jul 2015 09:40:32 +0200 [thread overview]
Message-ID: <20150710074032.GA7343@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1507091404200.17177@chino.kir.corp.google.com>
On Thu 09-07-15 14:07:37, David Rientjes wrote:
> On Thu, 9 Jul 2015, Michal Hocko wrote:
[...]
> > So I am not
> > sure it belongs outside of the oom killer proper.
> >
>
> Umm it has nothing to do with oom killing, it quite obviously doesn't
> belong in the oom killer.
The naming of the API would disagree. To me register_oom_notifier sounds
like a mechanism to be notified when we are oom.
> It belongs prior to invoking the oom killer if memory could be freed.
Shrinkers are there to reclaim and prevent from OOM. This API is a gray
zone. It looks generic method for the notification yet it allows to
prevent from oom killer. I can imagine somebody might abuse this
interface to implement OOM killer policies.
Anyway, I think it would be preferable to kill it altogether rather than
play with its placing. It will always be a questionable API.
[...]
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-10 7:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 13:04 [PATCH 0/4] oom: sysrq+f fixes + cleanups Michal Hocko
2015-07-08 13:04 ` [PATCH 1/4] oom: Do not panic when OOM killer is sysrq triggered Michal Hocko
2015-07-08 23:36 ` David Rientjes
2015-07-09 8:23 ` Michal Hocko
2015-07-09 21:03 ` David Rientjes
2015-07-10 7:41 ` Michal Hocko
2015-07-08 13:04 ` [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f Michal Hocko
2015-07-08 23:37 ` David Rientjes
2015-07-09 8:55 ` Michal Hocko
2015-07-09 21:07 ` David Rientjes
2015-07-10 7:40 ` Michal Hocko [this message]
2015-07-14 21:58 ` David Rientjes
2015-07-15 9:42 ` Michal Hocko
2015-07-15 22:21 ` David Rientjes
2015-07-15 22:44 ` [patch -mm] mm, oom: move oom notifiers to page allocator David Rientjes
2015-07-16 7:12 ` Michal Hocko
2015-07-08 13:04 ` [PATCH 3/4] mm, oom: organize oom context into struct Michal Hocko
2015-07-08 23:38 ` David Rientjes
2015-07-09 8:56 ` Michal Hocko
2015-07-09 21:09 ` David Rientjes
2015-07-08 13:04 ` [PATCH 4/4] oom: split out forced OOM killer Michal Hocko
2015-07-08 23:41 ` David Rientjes
2015-07-09 10:05 ` Michal Hocko
2015-07-09 21:27 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710074032.GA7343@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jakobunt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).