From: Mel Gorman <mgorman@suse.de>
To: PINTU KUMAR <pintu.k@samsung.com>
Cc: akpm@linux-foundation.org, corbet@lwn.net, vbabka@suse.cz,
gorcunov@openvz.org, mhocko@suse.cz, emunson@akamai.com,
kirill.shutemov@linux.intel.com, standby24x7@gmail.com,
hannes@cmpxchg.org, vdavydov@parallels.com, hughd@google.com,
minchan@kernel.org, tj@kernel.org, rientjes@google.com,
xypron.glpk@gmx.de, dzickus@redhat.com, prarit@redhat.com,
ebiederm@xmission.com, rostedt@goodmis.org, uobergfe@redhat.com,
paulmck@linux.vnet.ibm.com, iamjoonsoo.kim@lge.com,
ddstreet@ieee.org, sasha.levin@oracle.com, koct9i@gmail.com,
cj@linux.com, opensource.ganesh@gmail.com,
vinmenon@codeaurora.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-pm@vger.kernel.org, qiuxishi@huawei.com,
Valdis.Kletnieks@vt.edu, cpgs@samsung.com,
pintu_agarwal@yahoo.com, vishnu.ps@samsung.com,
rohit.kr@samsung.com, iqbal.ams@samsung.com,
pintu.ping@gmail.com, pintu.k@outlook.com
Subject: Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature
Date: Wed, 22 Jul 2015 15:05:30 +0100 [thread overview]
Message-ID: <20150722140530.GK2561@suse.de> (raw)
In-Reply-To: <05af01d0c47f$3337ccd0$99a76670$@samsung.com>
On Wed, Jul 22, 2015 at 06:33:26PM +0530, PINTU KUMAR wrote:
> Dear Mel, thank you very much for your comments and suggestions.
> I will drop this one and look on further improving direct_reclaim and
> compaction.
> Just few more comments below before I close.
>
> Also, during this patch, I feel that the hibernation_mode part in
> shrink_all_memory can be corrected.
> So, can I separately submit the below patch?
> That is instead of hard-coding the hibernation_mode, we can get hibernation
> status using:
> system_entering_hibernation()
>
> Please let me know your suggestion about this changes.
>
> -#ifdef CONFIG_HIBERNATION
> +#if defined CONFIG_HIBERNATION || CONFIG_SHRINK_MEMORY
This appears to be a patch on top of "Add /proc/sys/vm/shrink_memory
feature" so I do not see what would be separately submitted that would
make sense.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-22 14:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 13:20 [PATCH 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature Pintu Kumar
2015-07-03 17:21 ` Heinrich Schuchardt
2015-07-06 13:52 ` PINTU KUMAR
2015-07-03 18:38 ` Johannes Weiner
2015-07-04 6:04 ` PINTU KUMAR
2015-07-04 12:55 ` Johannes Weiner
2015-07-04 8:05 ` PINTU KUMAR
2015-07-04 20:08 ` Valdis.Kletnieks
2015-07-05 2:15 ` PINTU KUMAR
2015-07-05 8:20 ` PINTU KUMAR
2015-07-06 16:51 ` PINTU KUMAR
2015-07-06 10:22 ` Xishi Qiu
2015-07-06 14:03 ` PINTU KUMAR
2015-07-07 1:38 ` Xishi Qiu
2015-07-07 7:00 ` PINTU KUMAR
2015-07-17 6:29 ` [PATCHv2 " Pintu Kumar
2015-07-17 6:58 ` PINTU KUMAR
2015-07-20 4:29 ` [PATCH v3 " Pintu Kumar
2015-07-20 8:28 ` Mel Gorman
2015-07-20 8:49 ` Michal Hocko
2015-07-20 16:13 ` PINTU KUMAR
2015-07-20 17:55 ` Mel Gorman
2015-07-22 13:03 ` PINTU KUMAR
2015-07-22 14:05 ` Mel Gorman [this message]
2015-07-29 5:11 ` PINTU KUMAR
2015-07-29 12:07 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722140530.GK2561@suse.de \
--to=mgorman@suse.de \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=cj@linux.com \
--cc=corbet@lwn.net \
--cc=cpgs@samsung.com \
--cc=ddstreet@ieee.org \
--cc=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=emunson@akamai.com \
--cc=gorcunov@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=iqbal.ams@samsung.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=koct9i@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=opensource.ganesh@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pintu.k@outlook.com \
--cc=pintu.k@samsung.com \
--cc=pintu.ping@gmail.com \
--cc=pintu_agarwal@yahoo.com \
--cc=prarit@redhat.com \
--cc=qiuxishi@huawei.com \
--cc=rientjes@google.com \
--cc=rohit.kr@samsung.com \
--cc=rostedt@goodmis.org \
--cc=sasha.levin@oracle.com \
--cc=standby24x7@gmail.com \
--cc=tj@kernel.org \
--cc=uobergfe@redhat.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
--cc=vinmenon@codeaurora.org \
--cc=vishnu.ps@samsung.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).