Re: [PATCH mmotm] kexec: arch_kexec_apply_relocations can be static

["dyoung@redhat.com" <dyoung@redhat.com>]

Hi, Fengguang

On 07/24/15 at 06:30pm, Fengguang Wu wrote:
> Hi Dave,
> 
> On Fri, Jul 24, 2015 at 06:14:57PM +0800, dyoung@redhat.com wrote:
> > Hi, Fengguang
> > 
> > Justs be curious, is this been found by robot script?
> 
> Yes it is. :)
> 
> > On 07/24/15 at 04:11pm, kbuild test robot wrote:
> > > 
> > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > > ---
> > >  kexec_file.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> > > index caf47e9..91e9e9d 100644
> > > --- a/kernel/kexec_file.c
> > > +++ b/kernel/kexec_file.c
> > > @@ -122,7 +122,7 @@ arch_kexec_apply_relocations_add(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs,
> > >  }
> > >  
> > >  /* Apply relocations of type REL */
> > > -int __weak
> > > +static int __weak
> > >  arch_kexec_apply_relocations(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs,
> > >  			     unsigned int relsec)
> > >  {
> > 
> > It is a weak function, why move it to static? There's also several other similar
> > functions in the file.
> 
> Sorry we have detection logic for the weak symbols. However here it
> failed to work due to line wrapping. I'll fix it up.

No problem, thanks for explanation, nice work for the automation scripts..

Dave 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>