* [PATCH mmotm] kexec: arch_kexec_apply_relocations can be static [not found] <201507241644.XJlodOnm%fengguang.wu@intel.com> @ 2015-07-24 8:11 ` kbuild test robot 2015-07-24 10:14 ` dyoung 0 siblings, 1 reply; 4+ messages in thread From: kbuild test robot @ 2015-07-24 8:11 UTC (permalink / raw) To: dyoung@redhat.com Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- kexec_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index caf47e9..91e9e9d 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -122,7 +122,7 @@ arch_kexec_apply_relocations_add(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, } /* Apply relocations of type REL */ -int __weak +static int __weak arch_kexec_apply_relocations(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, unsigned int relsec) { -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH mmotm] kexec: arch_kexec_apply_relocations can be static 2015-07-24 8:11 ` [PATCH mmotm] kexec: arch_kexec_apply_relocations can be static kbuild test robot @ 2015-07-24 10:14 ` dyoung 2015-07-24 10:30 ` Fengguang Wu 0 siblings, 1 reply; 4+ messages in thread From: dyoung @ 2015-07-24 10:14 UTC (permalink / raw) To: kbuild test robot Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List Hi, Fengguang Justs be curious, is this been found by robot script? On 07/24/15 at 04:11pm, kbuild test robot wrote: > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > kexec_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > index caf47e9..91e9e9d 100644 > --- a/kernel/kexec_file.c > +++ b/kernel/kexec_file.c > @@ -122,7 +122,7 @@ arch_kexec_apply_relocations_add(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, > } > > /* Apply relocations of type REL */ > -int __weak > +static int __weak > arch_kexec_apply_relocations(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, > unsigned int relsec) > { It is a weak function, why move it to static? There's also several other similar functions in the file. Thanks Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH mmotm] kexec: arch_kexec_apply_relocations can be static 2015-07-24 10:14 ` dyoung @ 2015-07-24 10:30 ` Fengguang Wu 2015-07-24 10:48 ` dyoung 0 siblings, 1 reply; 4+ messages in thread From: Fengguang Wu @ 2015-07-24 10:30 UTC (permalink / raw) To: dyoung@redhat.com Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List Hi Dave, On Fri, Jul 24, 2015 at 06:14:57PM +0800, dyoung@redhat.com wrote: > Hi, Fengguang > > Justs be curious, is this been found by robot script? Yes it is. :) > On 07/24/15 at 04:11pm, kbuild test robot wrote: > > > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > --- > > kexec_file.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > > index caf47e9..91e9e9d 100644 > > --- a/kernel/kexec_file.c > > +++ b/kernel/kexec_file.c > > @@ -122,7 +122,7 @@ arch_kexec_apply_relocations_add(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, > > } > > > > /* Apply relocations of type REL */ > > -int __weak > > +static int __weak > > arch_kexec_apply_relocations(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, > > unsigned int relsec) > > { > > It is a weak function, why move it to static? There's also several other similar > functions in the file. Sorry we have detection logic for the weak symbols. However here it failed to work due to line wrapping. I'll fix it up. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH mmotm] kexec: arch_kexec_apply_relocations can be static 2015-07-24 10:30 ` Fengguang Wu @ 2015-07-24 10:48 ` dyoung 0 siblings, 0 replies; 4+ messages in thread From: dyoung @ 2015-07-24 10:48 UTC (permalink / raw) To: Fengguang Wu Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List Hi, Fengguang On 07/24/15 at 06:30pm, Fengguang Wu wrote: > Hi Dave, > > On Fri, Jul 24, 2015 at 06:14:57PM +0800, dyoung@redhat.com wrote: > > Hi, Fengguang > > > > Justs be curious, is this been found by robot script? > > Yes it is. :) > > > On 07/24/15 at 04:11pm, kbuild test robot wrote: > > > > > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > > --- > > > kexec_file.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > > > index caf47e9..91e9e9d 100644 > > > --- a/kernel/kexec_file.c > > > +++ b/kernel/kexec_file.c > > > @@ -122,7 +122,7 @@ arch_kexec_apply_relocations_add(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, > > > } > > > > > > /* Apply relocations of type REL */ > > > -int __weak > > > +static int __weak > > > arch_kexec_apply_relocations(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, > > > unsigned int relsec) > > > { > > > > It is a weak function, why move it to static? There's also several other similar > > functions in the file. > > Sorry we have detection logic for the weak symbols. However here it > failed to work due to line wrapping. I'll fix it up. No problem, thanks for explanation, nice work for the automation scripts.. Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-24 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201507241644.XJlodOnm%fengguang.wu@intel.com>
2015-07-24 8:11 ` [PATCH mmotm] kexec: arch_kexec_apply_relocations can be static kbuild test robot
2015-07-24 10:14 ` dyoung
2015-07-24 10:30 ` Fengguang Wu
2015-07-24 10:48 ` dyoung
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).