From: Oleg Nesterov <oleg@redhat.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: David Rientjes <rientjes@google.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: vm_flags, vm_flags_t and __nocast
Date: Mon, 3 Aug 2015 19:33:58 +0200 [thread overview]
Message-ID: <20150803173358.GA20243@redhat.com> (raw)
In-Reply-To: <20150803155155.7F8546E@black.fi.intel.com>
On 08/03, Kirill A. Shutemov wrote:
>
> Subject: [PATCH] mm: drop __nocast from vm_flags_t definition
>
> __nocast does no good for vm_flags_t. It only produces useless sparse
> warnings.
>
> Let's drop it.
Personally I like this change.
I too see no value in this "__nocast".
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> include/linux/mm_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index 1fb4e46a1736..b9134cc27c4d 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -226,7 +226,7 @@ struct page_frag {
> #endif
> };
>
> -typedef unsigned long __nocast vm_flags_t;
> +typedef unsigned long vm_flags_t;
>
> /*
> * A region containing a mapping of a non-memory backed file under NOMMU
> --
> 2.4.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-08-03 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 8:18 [mmotm:master 371/385] arch/x86/mm/mpx.c:71:54: sparse: implicit cast to nocast type kbuild test robot
2015-07-24 10:09 ` vm_flags, vm_flags_t and __nocast Kirill A. Shutemov
2015-07-24 20:15 ` David Rientjes
2015-08-03 15:51 ` Kirill A. Shutemov
2015-08-03 17:33 ` Oleg Nesterov [this message]
2015-08-06 2:07 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803173358.GA20243@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).