From: Andrew Morton <akpm@linux-foundation.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Tony Luck <tony.luck@intel.com>,
Pekka Enberg <penberg@kernel.org>, Mel Gorman <mgorman@suse.de>,
Baoquan He <bhe@redhat.com>, Tang Chen <tangchen@cn.fujitsu.com>,
Robin Holt <holt@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] mm/memblock: validate the creation of debugfs files
Date: Sat, 15 Aug 2015 00:52:43 -0700 [thread overview]
Message-ID: <20150815005243.aab83953.akpm@linux-foundation.org> (raw)
In-Reply-To: <20150815074850.GA2866@localhost>
On Sat, 15 Aug 2015 13:48:50 +0600 Alexander Kuleshov <kuleshovmail@gmail.com> wrote:
> On 08-15-15, Andrew Morton wrote:
> > Yes, I agree that if memblock's debugfs_create_file() fails, we want to
> > know about it because something needs fixing. But that's true of
> > all(?) debugfs_create_file callsites, so it's a bit silly to add
> > warnings to them all. Why not put the warning into
> > debugfs_create_file() itself?
>
> Good idea, but there are already some debugfs_create_file calls with checks and
> warning, if these checks failed. I don't know how many, but I saw it.
> Double warning is not good too.
Please ponder the sentence you deleted. "Or add a
debugfs_create_file_warn() wrapper".
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-08-15 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 19:03 [PATCH] mm/memblock: validate the creation of debugfs files Alexander Kuleshov
2015-08-14 21:19 ` Andrew Morton
2015-08-15 7:26 ` Alexander Kuleshov
2015-08-15 7:38 ` Andrew Morton
2015-08-15 7:48 ` Alexander Kuleshov
2015-08-15 7:52 ` Andrew Morton [this message]
2015-08-15 16:07 ` Greg Kroah-Hartman
2015-08-17 22:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150815005243.aab83953.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=holt@sgi.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=penberg@kernel.org \
--cc=tangchen@cn.fujitsu.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).