From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by kanga.kvack.org (Postfix) with ESMTP id 4A64C6B0038 for ; Sat, 15 Aug 2015 05:06:37 -0400 (EDT) Received: by wicja10 with SMTP id ja10so40772028wic.1 for ; Sat, 15 Aug 2015 02:06:36 -0700 (PDT) Received: from newverein.lst.de (verein.lst.de. [213.95.11.211]) by mx.google.com with ESMTPS id j10si15257612wjf.167.2015.08.15.02.06.35 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Aug 2015 02:06:36 -0700 (PDT) Date: Sat, 15 Aug 2015 11:06:35 +0200 From: Christoph Hellwig Subject: Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a tristate option Message-ID: <20150815090635.GF21033@lst.de> References: <20150813031253.36913.29580.stgit@otcpl-skl-sds-2.jf.intel.com> <20150813035028.36913.25267.stgit@otcpl-skl-sds-2.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150813035028.36913.25267.stgit@otcpl-skl-sds-2.jf.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Dan Williams Cc: linux-kernel@vger.kernel.org, boaz@plexistor.com, riel@redhat.com, linux-nvdimm@lists.01.org, david@fromorbit.com, mingo@kernel.org, linux-mm@kvack.org, mgorman@suse.de, ross.zwisler@linux.intel.com, torvalds@linux-foundation.org, hch@lst.de On Wed, Aug 12, 2015 at 11:50:29PM -0400, Dan Williams wrote: > Purely for ease of testing, with this in place we can run the unit test > alongside any tests that depend on the memmap=ss!nn kernel parameter. > The unit test mocking implementation requires that libnvdimm be a module > and not built-in. > > A nice side effect is the implementation is a bit more generic as it no > longer depends on . I really don't like this artifical split, and I also don't like how your weird "unit tests" force even more ugliness on the kernel. Almost reminds of the python projects spending more effort on getting their class mockable than actually producing results.. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org