linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.cz>,
	Mel Gorman <mgorman@techsingularity.net>,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm, vmscan: unlock page while waiting on writeback
Date: Fri, 21 Aug 2015 10:42:38 +0200	[thread overview]
Message-ID: <20150821084237.GA6619@cmpxchg.org> (raw)
In-Reply-To: <alpine.LSU.2.11.1508191930390.2073@eggly.anvils>

On Wed, Aug 19, 2015 at 07:36:31PM -0700, Hugh Dickins wrote:
> This is merely a politeness: I've not found that shrink_page_list() leads
> to deadlock with the page it holds locked across wait_on_page_writeback();
> but nevertheless, why hold others off by keeping the page locked there?
> 
> And while we're at it: remove the mistaken "not " from the commentary
> on this Case 3 (and a distracting blank line from Case 2, if I may).
> 
> Signed-off-by: Hugh Dickins <hughd@google.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2015-08-21  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20  2:36 [PATCH] mm, vmscan: unlock page while waiting on writeback Hugh Dickins
2015-08-20  8:09 ` Michal Hocko
2015-08-21  8:42 ` Johannes Weiner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150821084237.GA6619@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).