linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 1/3] mm, compaction: export tracepoints status strings to userspace
Date: Mon, 31 Aug 2015 10:55:38 -0400	[thread overview]
Message-ID: <20150831105538.2cf4b3ae@gandalf.local.home> (raw)
In-Reply-To: <1440689044-2922-1-git-send-email-vbabka@suse.cz>

On Thu, 27 Aug 2015 17:24:02 +0200
Vlastimil Babka <vbabka@suse.cz> wrote:

> Some compaction tracepoints convert the integer return values to strings using
> the compaction_status_string array. This works for in-kernel printing, but not
> userspace trace printing of raw captured trace such as via trace-cmd report.
> 
> This patch converts the private array to appropriate tracepoint macros that
> result in proper userspace support.
> 
> trace-cmd output before:
> transhuge-stres-4235  [000]   453.149280: mm_compaction_finished: node=0
>   zone=ffffffff81815d7a order=9 ret=
> 
> after:
> transhuge-stres-4235  [000]   453.149280: mm_compaction_finished: node=0
>   zone=ffffffff81815d7a order=9 ret=partial
> 

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: David Rientjes <rientjes@google.com>
> ---
>  include/trace/events/compaction.h | 33 +++++++++++++++++++++++++++++++--
>  mm/compaction.c                   | 11 -----------
>  2 files changed, 31 insertions(+), 13 deletions(-)
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-08-31 14:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 15:24 [PATCH 1/3] mm, compaction: export tracepoints status strings to userspace Vlastimil Babka
2015-08-27 15:24 ` [PATCH 2/3] mm, compaction: export tracepoints zone names " Vlastimil Babka
2015-08-31 14:58   ` Steven Rostedt
2015-08-31 15:02     ` Vlastimil Babka
2015-08-31 15:13       ` Steven Rostedt
2015-08-31 15:32   ` Steven Rostedt
2015-08-27 15:24 ` [PATCH 3/3] mm, compaction: disginguish contended status in tracepoint Vlastimil Babka
2015-09-07  5:53   ` Joonsoo Kim
2015-09-08 16:29     ` Vlastimil Babka
2015-08-31 14:55 ` Steven Rostedt [this message]
2015-08-31 15:27   ` [PATCH 1/3] mm, compaction: export tracepoints status strings to userspace Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150831105538.2cf4b3ae@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).