From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by kanga.kvack.org (Postfix) with ESMTP id 2B4D16B0255 for ; Mon, 31 Aug 2015 15:26:43 -0400 (EDT) Received: by pabpg12 with SMTP id pg12so16086075pab.3 for ; Mon, 31 Aug 2015 12:26:42 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by mx.google.com with ESMTP id i7si14815469pdo.233.2015.08.31.12.26.42 for ; Mon, 31 Aug 2015 12:26:42 -0700 (PDT) Date: Mon, 31 Aug 2015 13:26:40 -0600 From: Ross Zwisler Subject: Re: [PATCH] dax, pmem: add support for msync Message-ID: <20150831192640.GA15717@linux.intel.com> References: <1441047584-14664-1-git-send-email-ross.zwisler@linux.intel.com> <20150831190619.GA27141@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150831190619.GA27141@lst.de> Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: Ross Zwisler , linux-kernel@vger.kernel.org, Alexander Viro , Andrew Morton , Dave Hansen , "H. Peter Anvin" , Hugh Dickins , Ingo Molnar , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, Matthew Wilcox , Peter Zijlstra , Thomas Gleixner , x86@kernel.org On Mon, Aug 31, 2015 at 09:06:19PM +0200, Christoph Hellwig wrote: > On Mon, Aug 31, 2015 at 12:59:44PM -0600, Ross Zwisler wrote: > > For DAX msync we just need to flush the given range using > > wb_cache_pmem(), which is now a public part of the PMEM API. > > > > The inclusion of in fs/dax.c was done to make checkpatch > > happy. Previously it was complaining about a bunch of undeclared > > functions that could be made static. > > Should this be abstracted by adding a ->msync method? Maybe not > worth to do for now, but it might be worth to keep that in mind. Where would we add the ->msync method? Do you mean to the PMEM API, or somewhere else? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org