From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) by kanga.kvack.org (Postfix) with ESMTP id BD0B36B025C for ; Thu, 3 Sep 2015 12:45:13 -0400 (EDT) Received: by igbut12 with SMTP id ut12so44785372igb.1 for ; Thu, 03 Sep 2015 09:45:13 -0700 (PDT) Received: from mga01.intel.com (mga01.intel.com. [192.55.52.88]) by mx.google.com with ESMTP id os4si32674897pdb.152.2015.09.03.09.45.12 for ; Thu, 03 Sep 2015 09:45:13 -0700 (PDT) Date: Thu, 3 Sep 2015 10:44:53 -0600 From: Ross Zwisler Subject: Re: [PATCH] dax, pmem: add support for msync Message-ID: <20150903164453.GA10341@linux.intel.com> References: <1441047584-14664-1-git-send-email-ross.zwisler@linux.intel.com> <20150831233803.GO3902@dastard> <20150901070608.GA5482@lst.de> <55E597A1.9090205@plexistor.com> <20150902190401.GC32255@linux.intel.com> <55E7E962.2000607@plexistor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E7E962.2000607@plexistor.com> Sender: owner-linux-mm@kvack.org List-ID: To: Boaz Harrosh Cc: Ross Zwisler , Christoph Hellwig , Dave Chinner , Andrew Morton , Dave Hansen , linux-nvdimm@lists.01.org, Peter Zijlstra , x86@kernel.org, Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Alexander Viro , "H. Peter Anvin" , linux-fsdevel@vger.kernel.org, Thomas Gleixner , "Kirill A. Shutemov" On Thu, Sep 03, 2015 at 09:32:02AM +0300, Boaz Harrosh wrote: > On 09/02/2015 10:04 PM, Ross Zwisler wrote: > > On Tue, Sep 01, 2015 at 03:18:41PM +0300, Boaz Harrosh wrote: > <> > >> Apps expect all these to work: > >> 1. open mmap m-write msync ... close > >> 2. open mmap m-write fsync ... close > >> 3. open mmap m-write unmap ... fsync close > >> > >> 4. open mmap m-write sync ... > > > > So basically you made close have an implicit fsync? What about the flow that > > looks like this: > > > > 5. open mmap close m-write > > > > What? no, close means ummap because you need a file* attached to your vma > > And you miss-understood me, the vm_opts->close is the *unmap* operation not > the file::close() operation. > > I meant memory-cl_flush on unmap before the vma goes away. Ah, got it, thanks for the clarification. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org