From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f45.google.com (mail-la0-f45.google.com [209.85.215.45]) by kanga.kvack.org (Postfix) with ESMTP id CA73B6B0038 for ; Mon, 7 Sep 2015 06:01:25 -0400 (EDT) Received: by laeb10 with SMTP id b10so49387949lae.1 for ; Mon, 07 Sep 2015 03:01:25 -0700 (PDT) Received: from relay.parallels.com (relay.parallels.com. [195.214.232.42]) by mx.google.com with ESMTPS id n4si10014171lbc.63.2015.09.07.03.01.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Sep 2015 03:01:24 -0700 (PDT) Date: Mon, 7 Sep 2015 13:01:10 +0300 From: Vladimir Davydov Subject: Re: [PATCH 4/4] memcg: always enable kmemcg on the default hierarchy Message-ID: <20150907100110.GA31800@esperanza> References: <1440775530-18630-1-git-send-email-tj@kernel.org> <1440775530-18630-5-git-send-email-tj@kernel.org> <20150828164918.GJ9610@esperanza> <20150828171438.GD21463@dhcp22.suse.cz> <20150828174140.GN26785@mtj.duckdns.org> <20150901124459.GC8810@dhcp22.suse.cz> <20150901185157.GD18956@htj.dyndns.org> <20150904133038.GC8220@dhcp22.suse.cz> <20150904153810.GD13699@esperanza> <20150907093905.GD6022@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150907093905.GD6022@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Tejun Heo , hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com On Mon, Sep 07, 2015 at 11:39:06AM +0200, Michal Hocko wrote: ... > > > I might be wrong here of course but if the default should be switched it > > > would deserve a better justification with some numbers so that people > > > can see the possible drawbacks. > > > > Personally, I'd prefer to have it switched on by default, because it > > would force people test it and report bugs and performance degradation. > > If one finds it really crappy, he/she should be able to disable it. > > I do not think this is the way of introducing new functionality. You do > not want to force users to debug your code and go let it disable if it > is too crappy. One must first enable CONFIG_KMEM, which is off by default. Anyway, we aren't talking about enabling it by default in the legacy hierarchy, only in the unified hierarchy, which must be explicitly enabled by passing __DEVEL__save_behavior. I think that's enough. > > > > I agree that the per-cgroup knob is better than the global one. We > > > > Not that sure :-/ > > Why? I'm not sure there is use cases which need having kmem acct enabled in one cgroup and disabled in another. Thanks, Vladimir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org