From: Oleg Nesterov <oleg@redhat.com>
To: Chen Gang <xili_gchen_5257@hotmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"riel@redhat.com" <riel@redhat.com>,
Michal Hocko <mhocko@suse.cz>,
"sasha.levin@oracle.com" <sasha.levin@oracle.com>,
"pfeiner@google.com" <pfeiner@google.com>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"vishnu.ps@samsung.com" <vishnu.ps@samsung.com>,
Linux Memory <linux-mm@kvack.org>,
kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/mmap.c: Remove useless statement "vma = NULL" in find_vma()
Date: Thu, 10 Sep 2015 20:19:35 +0200 [thread overview]
Message-ID: <20150910181935.GB21456@redhat.com> (raw)
In-Reply-To: <COL130-W43C0C45AA4E2A7AA6361D0B9520@phx.gbl>
On 09/10, Chen Gang wrote:
>
> On 9/10/15 00:26, Oleg Nesterov wrote:
> >
> > The implementation looks correct. Why do you think it can be not 1st vma?
> >
>
> It is in while (rb_node) {...}.
>
> - When we set "vma = tmp", it is alreay match "addr < vm_end".
Yes,
> - If "addr>= vm_start", we return this vma (else continue searching).
This is optimization, we can stop the search because in this case
vma == tmp is obviously the 1st vma with "addr < vm_end".
I simply can't understand your concerns. Perhaps you can make a
patch, then it will be more clear what me-or-you have missed.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-10 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 14:03 [PATCH] mm/mmap.c: Remove useless statement "vma = NULL" in find_vma() Chen Gang
2015-09-07 12:36 ` Oleg Nesterov
[not found] ` <55EEED66.6090509@hotmail.com>
2015-09-08 14:14 ` Chen Gang
2015-09-09 16:26 ` Oleg Nesterov
[not found] ` <55F0B6C2.2000706@hotmail.com>
2015-09-09 22:44 ` Chen Gang
2015-09-10 18:19 ` Oleg Nesterov [this message]
2015-09-10 22:20 ` Chen Gang
2015-09-08 23:14 ` David Rientjes
-- strict thread matches above, loose matches on Subject: below --
2015-09-03 3:52 gang.chen.5i5j
2015-09-03 4:02 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910181935.GB21456@redhat.com \
--to=oleg@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=pfeiner@google.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=vishnu.ps@samsung.com \
--cc=xili_gchen_5257@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).