From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f53.google.com (mail-qg0-f53.google.com [209.85.192.53]) by kanga.kvack.org (Postfix) with ESMTP id 88E206B0253 for ; Mon, 14 Sep 2015 12:03:50 -0400 (EDT) Received: by qgt47 with SMTP id 47so118655276qgt.2 for ; Mon, 14 Sep 2015 09:03:50 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id d139si12612179qhc.110.2015.09.14.09.03.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Sep 2015 09:03:49 -0700 (PDT) Date: Mon, 14 Sep 2015 09:03:48 -0700 From: Greg KH Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes Message-ID: <20150914160348.GA7290@kroah.com> References: <81516fb9c662cc338b5af5b63fbbcde5374e0893.1442202447.git.viresh.kumar@linaro.org> <1708603.aKpYchk1pa@wuerfel> <20150914154708.GF32551@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150914154708.GF32551@linux> Sender: owner-linux-mm@kvack.org List-ID: To: Viresh Kumar Cc: Arnd Bergmann , linaro-kernel@lists.linaro.org, "open list:NETWORKING DRIVERS WIRELESS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Avri Altman , Stanislaw Gruszka , Jiri Slaby , "open list:DOCUMENTATION" , Peter Zijlstra , Catalin Marinas , Mark Brown , Jaroslav Kysela , "open list:MEMORY MANAGEMENT" , Kalle Valo , Emmanuel Grumbach , Wang Long , Richard Fitzgerald , Ingo Molnar , Johan Hedberg , Davidlohr Bueso , Joonsoo Kim , Jonathan Corbet , Joerg Roedel , "open list:WOLFSON MICROELECTRONICS DRIVERS" , Sebastian Ott , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , Intel Linux Wireless , "open list:ACPI" , "open list:QUALCOMM ATHEROS ATH9K WIRELESS DRIVER" , Nick Kossifidis , "open list:B43 WIRELESS DRIVER" , Luciano Coelho , Doug Thompson , Gustavo Padovan , Sasha Levin , Tomas Winkler , Sebastian Andrzej Siewior , sboyd@codeaurora.org, Len Brown , Takashi Iwai , Hariprasad S , Johannes Berg , Mauro Carvalho Chehab , Vlastimil Babka , Arik Nemtsov , Marcel Holtmann , David Rientjes , Michal Hocko , Akinobu Mita , QCA ath9k Development , Michael Kerrisk , Tejun Heo , Florian Fainelli , Borislav Petkov , Oleg Nesterov , Charles Keepax , Mel Gorman , "moderated list:ARM64 PORT AARCH64 ARCHITECTURE" , "open list:EDAC-CORE" , Haggai Eran , "James E.J. Bottomley" , Chaya Rachel Ivgi , "open list:CISCO SCSI HBA DRIVER" , Brian Silverman , "Luis R. Rodriguez" , "open list:CXGB4 ETHERNET DRIVER CXGB4" , "open list:ULTRA-WIDEBAND UWB SUBSYSTEM:" , Rafael Wysocki , Liam Girdwood , Sesidhar Baddela , open list , "open list:BLUETOOTH DRIVERS" , "open list:AMD IOMMU AMD-VI" , Dmitry Monakhov , Thomas Gleixner , Narsimhulu Musini , Johannes Weiner , Joe Perches , Eliad Peller , Andrew Morton , Alexander Duyck , Larry Finger On Mon, Sep 14, 2015 at 09:17:08PM +0530, Viresh Kumar wrote: > On 14-09-15, 17:39, Arnd Bergmann wrote: > > On Monday 14 September 2015 09:21:54 Viresh Kumar wrote: > > > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c > > > index b4c216bab22b..bea8e425a8de 100644 > > > --- a/drivers/acpi/ec_sys.c > > > +++ b/drivers/acpi/ec_sys.c > > > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) > > > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe)) > > > goto error; > > > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, > > > - (u32 *)&first_ec->global_lock)) > > > + &first_ec->global_lock)) > > > goto error; > > > > > > if (write_support) > > > > This one might need a separate patch that can be backported to stable, as > > the original code is already broken on big-endian 64-bit machines: > > global_lock is 'unsigned long'. > > Hmmm, so you suggest a single patch that will do s/unsigned long/u32 > and that will be followed with this patch (almost) as is. Right? > > Also, regarding the stable thing, we will surely not be able to > backport it straight away. But we should get it backported for sure. > > @Greg: What all kernel versions you want this to be backported for? What ever ones you think it is relevant for :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org