From: Tejun Heo <tj@kernel.org>
To: lizefan@huawei.com
Cc: cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@suse.cz,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] cgroup, memcg, cpuset: implement cgroup_taskset_for_each_leader()
Date: Mon, 14 Sep 2015 16:49:07 -0400 [thread overview]
Message-ID: <20150914204907.GI25369@htj.duckdns.org> (raw)
In-Reply-To: <1441998022-12953-3-git-send-email-tj@kernel.org>
On Fri, Sep 11, 2015 at 03:00:19PM -0400, Tejun Heo wrote:
> It wasn't explicitly documented but, when a process is being migrated,
> cpuset and memcg depend on cgroup_taskset_first() returning the
> threadgroup leader; however, this approach is somewhat ghetto and
> would no longer work for the planned multi-process migration.
>
> This patch introduces explicit cgroup_taskset_for_each_leader() which
> iterates over only the threadgroup leaders and replaces
> cgroup_taskset_first() usages for accessing the leader with it.
>
> This prepares both memcg and cpuset for multi-process migration. This
> patch also updates the documentation for cgroup_taskset_for_each() to
> clarify the iteration rules and removes comments mentioning task
> ordering in tasksets.
>
> v2: A previous patch which added threadgroup leader test was dropped.
> Patch updated accordingly.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Acked-by: Zefan Li <lizefan@huawei.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@suse.cz>
Michal, if you're okay with this patch, I'll apply the patchset in
cgroup/for-4.4.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-14 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 19:00 [PATCHSET v2 cgroup/for-4.4] cgroup: make multi-process migration atomic Tejun Heo
2015-09-11 19:00 ` [PATCH 1/5] cpuset: migrate memory only for threadgroup leaders Tejun Heo
2015-09-11 19:00 ` [PATCH 2/5] cgroup, memcg, cpuset: implement cgroup_taskset_for_each_leader() Tejun Heo
2015-09-14 20:49 ` Tejun Heo [this message]
2015-09-18 16:04 ` Tejun Heo
2015-09-22 15:49 ` Michal Hocko
2015-09-11 19:00 ` [PATCH 3/5] reorder cgroup_migrate()'s parameters Tejun Heo
2015-09-11 19:00 ` [PATCH 4/5] cgroup: separate out taskset operations from cgroup_migrate() Tejun Heo
2015-09-11 19:00 ` [PATCH 5/5] cgroup: make cgroup_update_dfl_csses() migrate all target processes atomically Tejun Heo
2015-09-22 16:48 ` [PATCHSET v2 cgroup/for-4.4] cgroup: make multi-process migration atomic Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914204907.GI25369@htj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).