[RFC][PATCH] mm: make zbud znd zpool to depend on zswap

[RFC][PATCH] mm: make zbud znd zpool to depend on zswap

[Sergey Senozhatsky]

There are no zbud and zpool users besides zswap so enabling
(and building) CONFIG_ZPOOL and CONFIG_ZBUD make sense only
when CONFIG_ZSWAP is enabled. In other words, make those
options to depend on CONFIG_ZSWAP.

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
 mm/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/Kconfig b/mm/Kconfig
index 3455a8d..eb48422 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -563,6 +563,7 @@ config ZSWAP
 
 config ZPOOL
 	tristate "Common API for compressed memory storage"
+	depends on ZSWAP
 	default n
 	help
 	  Compressed memory storage API.  This allows using either zbud or
@@ -570,6 +571,7 @@ config ZPOOL
 
 config ZBUD
 	tristate "Low density storage for compressed pages"
+	depends on ZSWAP
 	default n
 	help
 	  A special purpose allocator for storing compressed pages.
-- 
2.5.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [RFC][PATCH] mm: make zbud znd zpool to depend on zswap

[Dan Streetman]

On Thu, Sep 10, 2015 at 8:28 AM, Sergey Senozhatsky
<sergey.senozhatsky@gmail.com> wrote:
> There are no zbud and zpool users besides zswap so enabling
> (and building) CONFIG_ZPOOL and CONFIG_ZBUD make sense only
> when CONFIG_ZSWAP is enabled. In other words, make those
> options to depend on CONFIG_ZSWAP.

Let's wait on this until the patches to add zpool support to zram go
one way or the other.  If they don't make it in, I'm fine with this,
and even moving the zpool.h header into mm/ instead of include/linux/

>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
>  mm/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 3455a8d..eb48422 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -563,6 +563,7 @@ config ZSWAP
>
>  config ZPOOL
>         tristate "Common API for compressed memory storage"
> +       depends on ZSWAP
>         default n
>         help
>           Compressed memory storage API.  This allows using either zbud or
> @@ -570,6 +571,7 @@ config ZPOOL
>
>  config ZBUD
>         tristate "Low density storage for compressed pages"
> +       depends on ZSWAP
>         default n
>         help
>           A special purpose allocator for storing compressed pages.
> --
> 2.5.1
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [RFC][PATCH] mm: make zbud znd zpool to depend on zswap

[Sergey Senozhatsky]

On (09/15/15 02:06), Dan Streetman wrote:
> > There are no zbud and zpool users besides zswap so enabling
> > (and building) CONFIG_ZPOOL and CONFIG_ZBUD make sense only
> > when CONFIG_ZSWAP is enabled. In other words, make those
> > options to depend on CONFIG_ZSWAP.
> 
> Let's wait on this until the patches to add zpool support to zram go
> one way or the other.  If they don't make it in, I'm fine with this,
> and even moving the zpool.h header into mm/ instead of include/linux/
> 

agree.

	-ss

> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > ---
> >  mm/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/mm/Kconfig b/mm/Kconfig
> > index 3455a8d..eb48422 100644
> > --- a/mm/Kconfig
> > +++ b/mm/Kconfig
> > @@ -563,6 +563,7 @@ config ZSWAP
> >
> >  config ZPOOL
> >         tristate "Common API for compressed memory storage"
> > +       depends on ZSWAP
> >         default n
> >         help
> >           Compressed memory storage API.  This allows using either zbud or
> > @@ -570,6 +571,7 @@ config ZPOOL
> >
> >  config ZBUD
> >         tristate "Low density storage for compressed pages"
> > +       depends on ZSWAP
> >         default n
> >         help
> >           A special purpose allocator for storing compressed pages.
> > --
> > 2.5.1
> >
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>