From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Shaohua Li <shli@fb.com>,
linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] memcg: convert threshold to bytes
Date: Wed, 7 Oct 2015 09:30:02 +0200 [thread overview]
Message-ID: <20151007073002.GA17444@dhcp22.suse.cz> (raw)
In-Reply-To: <20151006122225.8a499b42f49d8484b61632a8@linux-foundation.org>
On Tue 06-10-15 12:22:25, Andrew Morton wrote:
> On Tue, 6 Oct 2015 19:01:23 +0200 Michal Hocko <mhocko@kernel.org> wrote:
>
> > On Mon 05-10-15 14:44:22, Shaohua Li wrote:
> > > The page_counter_memparse() returns pages for the threshold, while
> > > mem_cgroup_usage() returns bytes for memory usage. Convert the threshold
> > > to bytes.
> > >
> > > Looks a regression introduced by 3e32cb2e0a12b69150
> >
> > Yes. This suggests
> > Cc: stable # 3.19+
>
> But it's been this way for 2 years and nobody noticed it. How come?
Maybe we do not have that many users of this API with newer kernels.
> Or at least, nobody reported it. Maybe people *have* noticed it, and
> adjusted their userspace appropriately. In which case this patch will
> cause breakage.
I dunno, I would rather have it fixed than keep bug to bug compatibility
because they would eventually move to a newer kernel one day when they
see the "breakage" anyway.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-10-07 7:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 21:44 [PATCH] memcg: convert threshold to bytes Shaohua Li
2015-10-05 22:03 ` Andrew Morton
2015-10-06 17:01 ` Michal Hocko
2015-10-06 19:22 ` Andrew Morton
2015-10-07 7:30 ` Michal Hocko [this message]
2015-10-07 7:58 ` Andrew Morton
2015-10-07 8:30 ` Michal Hocko
2015-10-07 15:25 ` Shaohua Li
2015-10-07 15:56 ` Greg Thelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007073002.GA17444@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).