From: Jerome Glisse <j.glisse@gmail.com>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: 'Jerome Glisse' <jglisse@redhat.com>,
linux-mm@kvack.org, 'linux-kernel' <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 02/14] HMM: add special swap filetype for memory migrated to device v2.
Date: Thu, 22 Oct 2015 23:54:10 -0400 [thread overview]
Message-ID: <20151023035409.GA4404@gmail.com> (raw)
In-Reply-To: <070501d10d42$2ec35190$8c49f4b0$@alibaba-inc.com>
On Fri, Oct 23, 2015 at 11:23:26AM +0800, Hillf Danton wrote:
> > > > + if (cnt_hmm_entry) {
> > > > + int ret;
> > > > +
> > > > + ret = hmm_mm_fork(src_mm, dst_mm, dst_vma,
> > > > + dst_pmd, start, end);
> > >
> > > Given start, s/end/addr/, no?
> >
> > No, end is the right upper limit here.
> >
> Then in the first loop, hmm_mm_fork is invoked for
> the _entire_ range, from input addr to end.
> In subsequent loops(if necessary), start is updated to
> addr, and hmm_mm_fork is also invoked for remaining
> range, from start to end.
>
> Is the above overlap in range making sense?
Well yes and no, hmm_mm_fork() will do nothing for address >= addr
i feel like end is easier to understand.
Cheers,
Jerome
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-10-23 3:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <05ec01d10c9b$4df7ba80$e9e72f80$@alibaba-inc.com>
2015-10-22 7:52 ` [PATCH v11 02/14] HMM: add special swap filetype for memory migrated to device v2 Hillf Danton
2015-10-22 14:21 ` Jerome Glisse
2015-10-23 3:23 ` Hillf Danton
2015-10-23 3:54 ` Jerome Glisse [this message]
2015-10-21 21:10 [PATCH v11 00/14] HMM anomymous memory migration to device memory Jérôme Glisse
2015-10-21 21:10 ` [PATCH v11 02/14] HMM: add special swap filetype for memory migrated to device v2 Jérôme Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023035409.GA4404@gmail.com \
--to=j.glisse@gmail.com \
--cc=hillf.zj@alibaba-inc.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).