From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by kanga.kvack.org (Postfix) with ESMTP id D0A816B0038 for ; Mon, 26 Oct 2015 20:32:12 -0400 (EDT) Received: by wijp11 with SMTP id p11so190436190wij.0 for ; Mon, 26 Oct 2015 17:32:12 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id az3si14151670wjb.67.2015.10.26.17.32.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 26 Oct 2015 17:32:11 -0700 (PDT) Date: Mon, 26 Oct 2015 17:32:02 -0700 From: Davidlohr Bueso Subject: Re: [PATCH 2/6] ksm: add cond_resched() to the rmap_walks Message-ID: <20151027003202.GG27292@linux-uzut.site> References: <1444925065-4841-1-git-send-email-aarcange@redhat.com> <1444925065-4841-3-git-send-email-aarcange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Andrea Arcangeli , Petr Holasek , linux-mm@kvack.org, Andrew Morton On Sun, 25 Oct 2015, Hugh Dickins wrote: >On Thu, 15 Oct 2015, Andrea Arcangeli wrote: > >> While at it add it to the file and anon walks too. >> >> Signed-off-by: Andrea Arcangeli > >Subject really should be "mm: add cond_resched() to the rmap walks", >then body "Add cond_resched() to the ksm and anon and file rmap walks." > >Acked-by: Hugh Dickins >but I think we need a blessing from Davidlohr too, if not more. Perhaps I'm lost in the context, but by the changelog alone I cannot see the reasoning for the patch. Are latencies really that high? Maybe, at least the changelog needs some love. Thanks, Davidlohr -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org