From: aris@redhat.com
To: linux-kerne@vger.kernel.org
Cc: linux-mm@kvack.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Michal Hocko <mhocko@kernel.org>,
Greg Thelen <gthelen@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>
Subject: [PATCH 3/5] dump_stack: introduce generic show_stack_lvl()
Date: Thu, 05 Nov 2015 17:30:17 -0500 [thread overview]
Message-ID: <20151105223014.856885835@redhat.com> (raw)
In-Reply-To: 20151105223014.701269769@redhat.com
[-- Attachment #1: introduce_generic_show_stack.patch --]
[-- Type: text/plain, Size: 1897 bytes --]
show_stack_lvl() works like show_stack() but allows also passing the log level.
The default implementation that should be overrided by architecture specific
code simply will call the existing show_stack().
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Greg Thelen <gthelen@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Aristeu Rozanski <aris@redhat.com>
---
include/linux/sched.h | 2 ++
lib/dump_stack.c | 8 +++++++-
2 files changed, 9 insertions(+), 1 deletion(-)
--- linux-2.6.orig/lib/dump_stack.c 2015-11-05 14:31:44.581921915 -0500
+++ linux-2.6/lib/dump_stack.c 2015-11-05 14:32:47.508211219 -0500
@@ -9,10 +9,16 @@
#include <linux/smp.h>
#include <linux/atomic.h>
+void __weak show_stack_lvl(struct task_struct *task, unsigned long *sp,
+ char *log_lvl)
+{
+ return show_stack(task, sp);
+}
+
static void __dump_stack(char *log_lvl)
{
dump_stack_print_info(log_lvl);
- show_stack(NULL, NULL);
+ show_stack_lvl(NULL, NULL, log_lvl);
}
/**
--- linux-2.6.orig/include/linux/sched.h 2015-11-05 14:31:44.581921915 -0500
+++ linux-2.6/include/linux/sched.h 2015-11-05 14:31:52.426833314 -0500
@@ -368,6 +368,8 @@ extern void show_regs(struct pt_regs *);
* trace (or NULL if the entire call-chain of the task should be shown).
*/
extern void show_stack(struct task_struct *task, unsigned long *sp);
+extern void show_stack_lvl(struct task_struct *task, unsigned long *sp,
+ char *log_lvl);
extern void cpu_init (void);
extern void trap_init(void);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-05 22:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 22:30 [PATCH 0/5] dump_stack: allow specifying printk log level aris
2015-11-05 22:30 ` [PATCH 1/5] dump_stack: pass log level to dump_stack_print_info() aris
2015-11-05 22:30 ` [PATCH 2/5] dump_stack: introduce dump_stack_lvl aris
2015-11-05 22:30 ` aris [this message]
2015-11-05 22:30 ` [PATCH 4/5] x86: dumpstack - implement show_stack_lvl() aris
2015-11-12 8:06 ` Ingo Molnar
2015-11-05 22:30 ` [PATCH 5/5] mm: use KERN_DEBUG for dump_stack() during an OOM aris
2015-11-12 10:26 ` Michal Hocko
2015-11-09 16:21 ` [PATCH 0/5] dump_stack: allow specifying printk log level Michal Hocko
2015-12-01 23:48 ` Andrew Morton
2015-12-02 13:53 ` Aristeu Rozanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105223014.856885835@redhat.com \
--to=aris@redhat.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=linux-kerne@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).