Re: [PATCH -mm v2] mm: add page_check_address_transhuge helper

[Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>]

On (11/24/15 11:09), Kirill A. Shutemov wrote:
[..]
> diff --git a/mm/page_idle.c b/mm/page_idle.c
> index 374931f32ebc..4ea9c4ef5146 100644
> --- a/mm/page_idle.c
> +++ b/mm/page_idle.c
> @@ -66,8 +66,12 @@ static int page_idle_clear_pte_refs_one(struct page *page,
>  	if (pte) {
>  		referenced = ptep_clear_young_notify(vma, addr, pte);
>  		pte_unmap(pte);
> -	} else
> +	} else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) {
>  		referenced = pmdp_clear_young_notify(vma, addr, pmd);
> +	} else {
> +		/* unexpected pmd-mapped page? */
> +		WARN_ON_ONCE(1);
> +	}
>  
>  	spin_unlock(ptl);
>  
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 27916086ac50..499b24511b1f 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -929,9 +929,12 @@ static int page_referenced_one(struct page *page, struct vm_area_struct *vma,
>  				referenced++;
>  		}
>  		pte_unmap(pte);
> -	} else {
> +	} else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) {
>  		if (pmdp_clear_flush_young_notify(vma, address, pmd))
>  			referenced++;
> +	} else {
> +		/* unexpected pmd-mapped page? */
> +		WARN_ON_ONCE(1);
>  	}
>  	spin_unlock(ptl);

yes, works for me.

	-ss

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>