* [linux-next:master 3174/3442] fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg'
@ 2015-11-26 8:45 kbuild test robot
2015-11-30 22:39 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-11-26 8:45 UTC (permalink / raw)
To: Ryan Ding; +Cc: kbuild-all, Andrew Morton, Linux Memory Management List
[-- Attachment #1: Type: text/plain, Size: 2186 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 7dd2ecb6facfd1ac1a1cccc908e88e20e65e5801
commit: 5d974dfe80b2322a6b0afc85beb15fe9bc233804 [3174/3442] ocfs2: fix ip_unaligned_aio deadlock with dio work queue
config: m68k-sun3_defconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 5d974dfe80b2322a6b0afc85beb15fe9bc233804
# save the attached .config to linux build tree
make.cross ARCH=m68k
All warnings (new ones prefixed by >>):
In file included from arch/m68k/include/asm/atomic.h:6:0,
from include/linux/atomic.h:4,
from include/linux/spinlock.h:406,
from include/linux/wait.h:8,
from include/linux/fs.h:5,
from fs/ocfs2/file.c:27:
fs/ocfs2/file.c: In function 'ocfs2_file_write_iter':
arch/m68k/include/asm/cmpxchg.h:78:22: warning: value computed is not used [-Wunused-value]
#define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
^
>> fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg'
xchg(&iocb->ki_complete, saved_ki_complete);
^
vim +/xchg +2297 fs/ocfs2/file.c
2281 written = ret;
2282
2283 if (!ret) {
2284 ret = jbd2_journal_force_commit(osb->journal->j_journal);
2285 if (ret < 0)
2286 written = ret;
2287 }
2288
2289 if (!ret)
2290 ret = filemap_fdatawait_range(file->f_mapping,
2291 iocb->ki_pos - written,
2292 iocb->ki_pos - 1);
2293 }
2294
2295 out:
2296 if (saved_ki_complete)
> 2297 xchg(&iocb->ki_complete, saved_ki_complete);
2298
2299 if (rw_level != -1)
2300 ocfs2_rw_unlock(inode, rw_level);
2301
2302 out_mutex:
2303 mutex_unlock(&inode->i_mutex);
2304
2305 if (written)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 11055 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [linux-next:master 3174/3442] fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg'
2015-11-26 8:45 [linux-next:master 3174/3442] fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg' kbuild test robot
@ 2015-11-30 22:39 ` Andrew Morton
2015-12-01 8:07 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2015-11-30 22:39 UTC (permalink / raw)
To: kbuild test robot
Cc: Ryan Ding, kbuild-all, Linux Memory Management List,
Geert Uytterhoeven
On Thu, 26 Nov 2015 16:45:21 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 7dd2ecb6facfd1ac1a1cccc908e88e20e65e5801
> commit: 5d974dfe80b2322a6b0afc85beb15fe9bc233804 [3174/3442] ocfs2: fix ip_unaligned_aio deadlock with dio work queue
> config: m68k-sun3_defconfig (attached as .config)
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 5d974dfe80b2322a6b0afc85beb15fe9bc233804
> # save the attached .config to linux build tree
> make.cross ARCH=m68k
>
> All warnings (new ones prefixed by >>):
>
> In file included from arch/m68k/include/asm/atomic.h:6:0,
> from include/linux/atomic.h:4,
> from include/linux/spinlock.h:406,
> from include/linux/wait.h:8,
> from include/linux/fs.h:5,
> from fs/ocfs2/file.c:27:
> fs/ocfs2/file.c: In function 'ocfs2_file_write_iter':
> arch/m68k/include/asm/cmpxchg.h:78:22: warning: value computed is not used [-Wunused-value]
> #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
> ^
> >> fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg'
> xchg(&iocb->ki_complete, saved_ki_complete);
> ^
>
> vim +/xchg +2297 fs/ocfs2/file.c
>
> 2281 written = ret;
> 2282
> 2283 if (!ret) {
> 2284 ret = jbd2_journal_force_commit(osb->journal->j_journal);
> 2285 if (ret < 0)
> 2286 written = ret;
> 2287 }
> 2288
> 2289 if (!ret)
> 2290 ret = filemap_fdatawait_range(file->f_mapping,
> 2291 iocb->ki_pos - written,
> 2292 iocb->ki_pos - 1);
> 2293 }
> 2294
> 2295 out:
> 2296 if (saved_ki_complete)
> > 2297 xchg(&iocb->ki_complete, saved_ki_complete);
> 2298
> 2299 if (rw_level != -1)
> 2300 ocfs2_rw_unlock(inode, rw_level);
> 2301
> 2302 out_mutex:
> 2303 mutex_unlock(&inode->i_mutex);
> 2304
> 2305 if (written)
Beats me. Maybe a glitch in the m68k compiler?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [linux-next:master 3174/3442] fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg'
2015-11-30 22:39 ` Andrew Morton
@ 2015-12-01 8:07 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2015-12-01 8:07 UTC (permalink / raw)
To: Andrew Morton
Cc: kbuild test robot, Ryan Ding, kbuild-all@01.org,
Linux Memory Management List
Hi Andrew,
On Mon, Nov 30, 2015 at 11:39 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 26 Nov 2015 16:45:21 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head: 7dd2ecb6facfd1ac1a1cccc908e88e20e65e5801
>> commit: 5d974dfe80b2322a6b0afc85beb15fe9bc233804 [3174/3442] ocfs2: fix ip_unaligned_aio deadlock with dio work queue
>> config: m68k-sun3_defconfig (attached as .config)
>> reproduce:
>> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> git checkout 5d974dfe80b2322a6b0afc85beb15fe9bc233804
>> # save the attached .config to linux build tree
>> make.cross ARCH=m68k
>>
>> All warnings (new ones prefixed by >>):
>>
>> In file included from arch/m68k/include/asm/atomic.h:6:0,
>> from include/linux/atomic.h:4,
>> from include/linux/spinlock.h:406,
>> from include/linux/wait.h:8,
>> from include/linux/fs.h:5,
>> from fs/ocfs2/file.c:27:
>> fs/ocfs2/file.c: In function 'ocfs2_file_write_iter':
>> arch/m68k/include/asm/cmpxchg.h:78:22: warning: value computed is not used [-Wunused-value]
>> #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
>> ^
>> >> fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg'
>> xchg(&iocb->ki_complete, saved_ki_complete);
>> ^
>>
>> vim +/xchg +2297 fs/ocfs2/file.c
>>
>> 2281 written = ret;
>> 2282
>> 2283 if (!ret) {
>> 2284 ret = jbd2_journal_force_commit(osb->journal->j_journal);
>> 2285 if (ret < 0)
>> 2286 written = ret;
>> 2287 }
>> 2288
>> 2289 if (!ret)
>> 2290 ret = filemap_fdatawait_range(file->f_mapping,
>> 2291 iocb->ki_pos - written,
>> 2292 iocb->ki_pos - 1);
>> 2293 }
>> 2294
>> 2295 out:
>> 2296 if (saved_ki_complete)
>> > 2297 xchg(&iocb->ki_complete, saved_ki_complete);
>> 2298
>> 2299 if (rw_level != -1)
>> 2300 ocfs2_rw_unlock(inode, rw_level);
>> 2301
>> 2302 out_mutex:
>> 2303 mutex_unlock(&inode->i_mutex);
>> 2304
>> 2305 if (written)
>
> Beats me. Maybe a glitch in the m68k compiler?
Known "issue" with the m68k xchg() macro implementation.
Should fix that, one day...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-01 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-26 8:45 [linux-next:master 3174/3442] fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg' kbuild test robot
2015-11-30 22:39 ` Andrew Morton
2015-12-01 8:07 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).