From: David Miller <davem@davemloft.net>
To: mhocko@kernel.org
Cc: pavel@ucw.cz, akpm@osdl.org, linux-kernel@vger.kernel.org,
jcliburn@gmail.com, chris.snook@gmail.com,
netdev@vger.kernel.org, rjw@rjwysocki.net, linux-mm@kvack.org,
nic-devel@qualcomm.com, ronangeles@gmail.com,
ebiederm@xmission.com
Subject: Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation
Date: Tue, 01 Dec 2015 15:35:17 -0500 (EST) [thread overview]
Message-ID: <20151201.153517.224543138214404348.davem@davemloft.net> (raw)
In-Reply-To: <20151130132129.GB21950@dhcp22.suse.cz>
From: Michal Hocko <mhocko@kernel.org>
Date: Mon, 30 Nov 2015 14:21:29 +0100
> On Sat 28-11-15 15:51:13, Pavel Machek wrote:
>>
>> atl1c driver is doing order-4 allocation with GFP_ATOMIC
>> priority. That often breaks networking after resume. Switch to
>> GFP_KERNEL. Still not ideal, but should be significantly better.
>
> It is not clear why GFP_KERNEL can replace GFP_ATOMIC safely neither
> from the changelog nor from the patch context.
Earlier in the function we do a GFP_KERNEL kmalloc so:
¯\_(ツ)_/¯
It should be fine.
next prev parent reply other threads:[~2015-12-01 20:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 16:34 4.3+: Atheros ethernet fails after resume from s2ram, due to order 4 allocation Pavel Machek
2015-11-26 21:56 ` Francois Romieu
2015-11-27 8:20 ` Michal Hocko
2015-11-28 14:50 ` Pavel Machek
2015-11-28 14:51 ` [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation Pavel Machek
2015-11-29 21:58 ` Sergei Shtylyov
2015-11-30 13:21 ` Michal Hocko
2015-12-01 20:35 ` David Miller [this message]
2015-12-02 22:43 ` Chris Snook
2015-12-03 7:49 ` Pavel Machek
2015-12-03 8:16 ` Michal Hocko
2015-12-03 19:26 ` Chris Snook
2015-11-30 17:58 ` Eric Dumazet
2015-12-01 20:36 ` David Miller
2015-12-03 15:59 ` Pavel Machek
2015-12-03 15:59 ` [PATCH net] atl1c: Improve " Pavel Machek
2015-12-03 16:13 ` Michal Hocko
2015-12-03 17:17 ` Eric Dumazet
2015-12-03 17:32 ` David Miller
2015-12-04 8:11 ` Pavel Machek
2015-12-04 16:21 ` David Miller
2015-12-04 21:30 ` Pavel Machek
2015-12-04 22:01 ` David Miller
2015-12-04 8:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201.153517.224543138214404348.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=chris.snook@gmail.com \
--cc=ebiederm@xmission.com \
--cc=jcliburn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ronangeles@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).