From: Pavel Machek <pavel@ucw.cz>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, mhocko@kernel.org, akpm@osdl.org,
linux-kernel@vger.kernel.org, jcliburn@gmail.com,
chris.snook@gmail.com, netdev@vger.kernel.org, rjw@rjwysocki.net,
linux-mm@kvack.org, nic-devel@qualcomm.com, ronangeles@gmail.com,
ebiederm@xmission.com
Subject: Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation
Date: Fri, 4 Dec 2015 09:11:27 +0100 [thread overview]
Message-ID: <20151204081127.GA29367@amd> (raw)
In-Reply-To: <20151203.123249.2158644928982094593.davem@davemloft.net>
> >> if (unlikely(!ring_header->desc)) {
> >> - dev_err(&pdev->dev, "pci_alloc_consistend failed\n");
> >> + dev_err(&pdev->dev, "could not get memory for DMA buffer\n");
> >> goto err_nomem;
> >> }
> >> memset(ring_header->desc, 0, ring_header->size);
> >>
> >>
> >
> > So this memset() will really require a different patch to get removed ?
> >
> > Sigh, not sure why I review patches.
>
> Agreed, please use dma_zalloc_coherent() and kill that memset().
Ok, updated. I'll also add cc: stable, because it makes notebooks with
affected chipset unusable.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-04 8:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 16:34 4.3+: Atheros ethernet fails after resume from s2ram, due to order 4 allocation Pavel Machek
2015-11-26 21:56 ` Francois Romieu
2015-11-27 8:20 ` Michal Hocko
2015-11-28 14:50 ` Pavel Machek
2015-11-28 14:51 ` [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation Pavel Machek
2015-11-29 21:58 ` Sergei Shtylyov
2015-11-30 13:21 ` Michal Hocko
2015-12-01 20:35 ` David Miller
2015-12-02 22:43 ` Chris Snook
2015-12-03 7:49 ` Pavel Machek
2015-12-03 8:16 ` Michal Hocko
2015-12-03 19:26 ` Chris Snook
2015-11-30 17:58 ` Eric Dumazet
2015-12-01 20:36 ` David Miller
2015-12-03 15:59 ` Pavel Machek
2015-12-03 15:59 ` [PATCH net] atl1c: Improve " Pavel Machek
2015-12-03 16:13 ` Michal Hocko
2015-12-03 17:17 ` Eric Dumazet
2015-12-03 17:32 ` David Miller
2015-12-04 8:11 ` Pavel Machek [this message]
2015-12-04 16:21 ` David Miller
2015-12-04 21:30 ` Pavel Machek
2015-12-04 22:01 ` David Miller
2015-12-04 8:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204081127.GA29367@amd \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=jcliburn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=rjw@rjwysocki.net \
--cc=ronangeles@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).