linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Daniel Cashman <dcashman@google.com>,
	kbuild-all@01.org, Mark Brown <broonie@kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 4174/4356] kernel/built-in.o:undefined reference to `mmap_rnd_bits'
Date: Fri, 4 Dec 2015 15:14:24 -0800	[thread overview]
Message-ID: <20151204151424.e73641da44c61f20f10d93e9@linux-foundation.org> (raw)
In-Reply-To: <201512050045.l2G9WhTi%fengguang.wu@intel.com>

On Sat, 5 Dec 2015 00:18:47 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   dcccebc04ddba852aad354270986d508e8f011c0
> commit: a8f025e63718534d6a9224a0b069b772ef21cb5d [4174/4356] arm: mm: support ARCH_MMAP_RND_BITS
> config: arm-vf610m4_defconfig (attached as .config)
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout a8f025e63718534d6a9224a0b069b772ef21cb5d
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm 
> 
> All errors (new ones prefixed by >>):
> 
> >> kernel/built-in.o:(.data+0x754): undefined reference to `mmap_rnd_bits'
> >> kernel/built-in.o:(.data+0x76c): undefined reference to `mmap_rnd_bits_min'
> >> kernel/built-in.o:(.data+0x770): undefined reference to `mmap_rnd_bits_max'

OK, the patches are pretty broken when HAVE_ARCH_MMAP_RND_BITS=n.  I
guess a pile of new ifdefs need adding for this case.

There's also the matter of CONFIG_MMU=n.  mm/mmap.o doesn't get
included in the build in this case, so that will also break things.  I
suggest that can be fixed by making HAVE_ARCH_MMAP_RND_BITS and
HAVE_ARCH_MMAP_RND_COMPAT_BITS depend on MMU.  That should fix things
up when combined with the new ifdef-sprinkling.

This stuff is going to break quite a lot of test builds so I think I'll
consolidate the patches then drop 'em for now.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-12-04 23:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 16:18 [linux-next:master 4174/4356] kernel/built-in.o:undefined reference to `mmap_rnd_bits' kbuild test robot
2015-12-04 23:14 ` Andrew Morton [this message]
2015-12-04 23:19   ` Andrew Morton
2015-12-05  0:56     ` Daniel Cashman
2015-12-05  1:01       ` Andrew Morton
2015-12-05  1:46         ` Daniel Cashman
2015-12-07 18:13           ` Daniel Cashman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151204151424.e73641da44c61f20f10d93e9@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=dcashman@google.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).