From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, yalin wang <yalin.wang2010@gmail.com>,
Willy Tarreau <w@1wt.eu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] fs: clear file privilege bits when mmap writing
Date: Thu, 10 Dec 2015 04:14:24 +0000 [thread overview]
Message-ID: <20151210041424.GD20997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20151209225148.GA14794@www.outflux.net>
On Wed, Dec 09, 2015 at 02:51:48PM -0800, Kees Cook wrote:
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 3aa514254161..409bd7047e7e 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -872,6 +872,7 @@ struct file {
> struct list_head f_tfile_llink;
> #endif /* #ifdef CONFIG_EPOLL */
> struct address_space *f_mapping;
> + bool f_remove_privs;
NAK. If anything, such things belong in ->f_flags. _If_ this is worth
doing at all, that is.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-10 4:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 22:51 [PATCH v5] fs: clear file privilege bits when mmap writing Kees Cook
2015-12-10 1:21 ` Christoph Hellwig
2015-12-10 3:25 ` Kees Cook
2015-12-10 4:14 ` Al Viro [this message]
2015-12-10 7:06 ` Willy Tarreau
2015-12-10 7:10 ` Willy Tarreau
2015-12-10 18:05 ` Kees Cook
2015-12-10 18:16 ` Willy Tarreau
2015-12-10 18:18 ` Kees Cook
2015-12-10 19:33 ` Al Viro
2015-12-10 19:47 ` Kees Cook
2015-12-10 20:27 ` Al Viro
2015-12-10 21:45 ` Kees Cook
2015-12-10 21:56 ` Al Viro
2015-12-10 22:00 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210041424.GD20997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=w@1wt.eu \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).