From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, Vladimir Davydov <vdavydov@virtuozzo.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
brouer@redhat.com
Subject: Re: [RFC PATCH V2 8/9] slab: implement bulk free in SLAB allocator
Date: Thu, 10 Dec 2015 16:10:18 +0100 [thread overview]
Message-ID: <20151210161018.28cedb68@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1512091338240.7552@east.gentwo.org>
On Wed, 9 Dec 2015 13:41:07 -0600 (CST)
Christoph Lameter <cl@linux.com> wrote:
> On Wed, 9 Dec 2015, Jesper Dangaard Brouer wrote:
>
> > I really like the idea of making it able to free kmalloc'ed objects.
> > But I hate to change the API again... (I do have a use-case in the
> > network stack where I could use this feature).
>
> Now is the time to fix the API since its not that much in use yet if at
> all.
Lets start the naming thread/flame (while waiting for my flight ;-))
If we drop the "kmem_cache *s" parameter from kmem_cache_free_bulk(),
and also make it handle kmalloc'ed objects. Why should we name it
"kmem_cache_free_bulk"? ... what about naming it kfree_bulk() ???
Or should we keep the name to have a symmetric API
kmem_cache_{alloc,free}_bulk() call convention?
I'm undecided...
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-10 15:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 15:56 [RFC PATCH 0/2] slab: implement bulking for SLAB allocator Jesper Dangaard Brouer
2015-12-03 15:57 ` [RFC PATCH 1/2] slab: implement bulk alloc in " Jesper Dangaard Brouer
2015-12-04 10:16 ` Jesper Dangaard Brouer
2015-12-04 17:10 ` Christoph Lameter
2015-12-07 10:20 ` Jesper Dangaard Brouer
2015-12-07 14:57 ` Christoph Lameter
2015-12-03 15:57 ` [RFC PATCH 2/2] slab: implement bulk free " Jesper Dangaard Brouer
2015-12-04 17:17 ` Christoph Lameter
2015-12-07 11:25 ` Jesper Dangaard Brouer
2015-12-07 14:59 ` Christoph Lameter
2015-12-08 13:39 ` Jesper Dangaard Brouer
2015-12-08 14:11 ` Christoph Lameter
2015-12-08 14:12 ` Vladimir Davydov
2015-12-08 14:15 ` Christoph Lameter
2015-12-08 14:56 ` Vladimir Davydov
2015-12-08 15:13 ` Jesper Dangaard Brouer
2015-12-08 15:32 ` Christoph Lameter
2015-12-04 9:01 ` [RFC PATCH 0/2] slab: implement bulking for " Jesper Dangaard Brouer
2015-12-08 16:18 ` [RFC PATCH V2 0/9] slab: cleanup and bulk API for SLAB Jesper Dangaard Brouer
2015-12-08 16:18 ` [RFC PATCH V2 1/9] mm/slab: move SLUB alloc hooks to common mm/slab.h Jesper Dangaard Brouer
2015-12-09 15:43 ` Christoph Lameter
2015-12-08 16:18 ` [RFC PATCH V2 2/9] mm: generalize avoid fault-inject on bootstrap kmem_cache Jesper Dangaard Brouer
2015-12-09 2:36 ` Joonsoo Kim
2015-12-08 16:18 ` [RFC PATCH V2 3/9] slab: use slab_pre_alloc_hook in SLAB allocator Jesper Dangaard Brouer
2015-12-08 16:18 ` [RFC PATCH V2 4/9] mm: kmemcheck skip object if slab allocation failed Jesper Dangaard Brouer
2015-12-08 16:18 ` [RFC PATCH V2 5/9] slab: use slab_post_alloc_hook in SLAB allocator Jesper Dangaard Brouer
2015-12-08 16:18 ` [RFC PATCH V2 6/9] slab: implement bulk alloc " Jesper Dangaard Brouer
2015-12-08 16:18 ` [RFC PATCH V2 7/9] slab: avoid running debug SLAB code with IRQs disabled for alloc_bulk Jesper Dangaard Brouer
2015-12-08 16:19 ` [RFC PATCH V2 8/9] slab: implement bulk free in SLAB allocator Jesper Dangaard Brouer
2015-12-09 16:06 ` Christoph Lameter
2015-12-09 18:53 ` Jesper Dangaard Brouer
2015-12-09 19:41 ` Christoph Lameter
2015-12-09 20:50 ` Jesper Dangaard Brouer
2015-12-10 15:15 ` Christoph Lameter
2015-12-10 15:10 ` Jesper Dangaard Brouer [this message]
2015-12-10 15:18 ` Christoph Lameter
2015-12-10 15:26 ` Vladimir Davydov
2015-12-10 17:24 ` Christoph Lameter
2015-12-14 15:19 ` Jesper Dangaard Brouer
2015-12-15 12:02 ` Jesper Dangaard Brouer
2015-12-08 16:19 ` [RFC PATCH V2 9/9] slab: annotate code to generate more compact asm code Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210161018.28cedb68@redhat.com \
--to=brouer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).