From: Michal Hocko <mhocko@suse.cz>
To: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mika Westerberg <mika.westerberg@intel.com>,
Hugh Dickins <hughd@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: mm related crash
Date: Mon, 14 Dec 2015 12:54:08 +0100 [thread overview]
Message-ID: <20151214115408.GC9544@dhcp22.suse.cz> (raw)
In-Reply-To: <CAPAsAGxkYf0b_ZzhyuvxyNcWWvAyXHehGJbeGUAgu2Zb2u=31Q@mail.gmail.com>
On Mon 14-12-15 14:14:41, Andrey Ryabinin wrote:
> 2015-12-14 13:57 GMT+03:00 Michal Hocko <mhocko@suse.cz>:
> > On Mon 14-12-15 13:13:22, Andrey Ryabinin wrote:
> >> 2015-12-14 13:05 GMT+03:00 Michal Hocko <mhocko@suse.cz>:
> >> > On Mon 14-12-15 11:24:33, Kirill A. Shutemov wrote:
> >> >> On Thu, Dec 10, 2015 at 05:48:01PM +0200, Mika Westerberg wrote:
> >> >> > Hi Kirill,
> >> >> >
> >> >> > I got following crash on my desktop machine while building swift. It
> >> >> > reproduces pretty easily on 4.4-rc4.
> >> >> >
> >> >> > Before it happens the ld process is killed by OOM killer. I attached the
> >> >> > whole dmesg.
> >> >> >
> >> >> > [ 254.740603] page:ffffea00111c31c0 count:2 mapcount:0 mapping: (null) index:0x0
> >> >> > [ 254.740636] flags: 0x5fff8000048028(uptodate|lru|swapcache|swapbacked)
> >> >> > [ 254.740655] page dumped because: VM_BUG_ON_PAGE(!PageLocked(page))
> >> >> > [ 254.740679] ------------[ cut here ]------------
> >> >> > [ 254.740690] kernel BUG at mm/memcontrol.c:5270!
> >> >>
> >> >>
> >> >> Hm. I don't see how this can happen.
> >> >
> >> > What a coincidence. I have just posted a similar report:
> >> > http://lkml.kernel.org/r/20151214100156.GA4540@dhcp22.suse.cz except I
> >> > have hit the VM_BUG_ON from a different path. My suspicion is that
> >> > somebody unlocks the page while we are waiting on the writeback.
> >> > I am trying to reproduce this now.
> >>
> >> Guys, this is fixed in rc5 - dfd01f026058a ("sched/wait: Fix the
> >> signal handling fix").
> >> http://lkml.kernel.org/r/<20151212162342.GF11257@ret.masoncoding.com>
> >
> > Hmm, so you think that some callpath was doing wait_on_page_locked and
> > the above bug would allow a race and then unlock the page under our
> > feet?
>
> It rather more simple, read report carefully from the link I gave.
> __wait_on_bit_lock() in __lock_page() could just return -EINTR and
> leave the page unlocked.
> So in rc4 lock_page() simply didn't work (sometimes).
Ohhh, right you are! Thanks for the clarification.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-14 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151210154801.GA12007@lahna.fi.intel.com>
2015-12-14 9:24 ` mm related crash Kirill A. Shutemov
2015-12-14 10:05 ` Michal Hocko
2015-12-14 10:13 ` Andrey Ryabinin
2015-12-14 10:57 ` Michal Hocko
2015-12-14 11:14 ` Andrey Ryabinin
2015-12-14 11:54 ` Michal Hocko [this message]
2015-12-14 12:11 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214115408.GC9544@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mika.westerberg@intel.com \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).