From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Quentin Casasnovas <quentin.casasnovas@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Vegard Nossum <vegard.nossum@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Willy Tarreau <w@1wt.eu>, Andy Lutomirski <luto@amacapital.net>,
Kees Cook <keescook@google.com>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA
Date: Mon, 14 Dec 2015 18:43:13 +0300 [thread overview]
Message-ID: <20151214154313.GF14045@uranus> (raw)
In-Reply-To: <20151214153234.GE3604@chrystal.uk.oracle.com>
On Mon, Dec 14, 2015 at 04:32:34PM +0100, Quentin Casasnovas wrote:
> >
> > growsup/down stand for stack usage iirc, so it was intentionally
> > not accounted here.
> >
>
> Right, but in the same vein of Linus saying RLIMIT_DATA is/was useless
> because everyone could use mmap() instead of brk() to get anonymous memory,
> what's the point of restricting "almost-all" anonymous memory if one can
> just use MAP_GROWSDOWN/UP and cause repeated page faults to extend that
> mapping, circumventing your checks? That makes the new restriction as
> useless as what RLIMIT_DATA used to be, doesn't it?
Not as it were before, but true, using growsdown/up will give a way
to allocate memory not limited byt rlimit-data. (Also I just noted
that I modified mm.h as well, where anon_accountable_mapping
was implemented but forgot to add it into quilt, so this patch
on its own won't compile, don't apply it).
> > >
> > > I only had a quick look so apologies if this is handled and I missed it :)
> >
> > thanks for feedback! also take a look on Kostya's patch, I think it's
> > even better approach (and I like it more than mine).
>
> Ha I'm not subscribed to LKML so I missed those, I suppose you can ignore
> my comments then! :)
https://lkml.org/lkml/2015/12/14/72
Take a look.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-12-14 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 20:14 [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA Cyrill Gorcunov
2015-12-14 8:12 ` Konstantin Khlebnikov
2015-12-14 8:12 ` [PATCH RFC] mm: rework virtual memory accounting Konstantin Khlebnikov
2015-12-14 9:08 ` Cyrill Gorcunov
2015-12-14 14:51 ` [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA Quentin Casasnovas
2015-12-14 15:11 ` Cyrill Gorcunov
2015-12-14 15:32 ` Quentin Casasnovas
2015-12-14 15:43 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214154313.GF14045@uranus \
--to=gorcunov@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=keescook@google.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=quentin.casasnovas@oracle.com \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov@virtuozzo.com \
--cc=vegard.nossum@oracle.com \
--cc=w@1wt.eu \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).