From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by kanga.kvack.org (Postfix) with ESMTP id CDC1D6B0038 for ; Mon, 14 Dec 2015 17:28:05 -0500 (EST) Received: by mail-wm0-f51.google.com with SMTP id n186so68577911wmn.0 for ; Mon, 14 Dec 2015 14:28:05 -0800 (PST) Received: from mail.skyhub.de (mail.skyhub.de. [2a01:4f8:120:8448::d00d]) by mx.google.com with ESMTP id xw2si48879112wjc.40.2015.12.14.14.28.04 for ; Mon, 14 Dec 2015 14:28:04 -0800 (PST) Date: Mon, 14 Dec 2015 23:27:59 +0100 From: Borislav Petkov Subject: Re: [PATCHV2 1/3] x86, ras: Add new infrastructure for machine check fixup tables Message-ID: <20151214222759.GF10520@pd.tnic> References: <456153d09e85f2f139020a051caed3ca8f8fca73.1449861203.git.tony.luck@intel.com> <20151212101142.GA3867@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Ross Zwisler Cc: Tony Luck , linux-nvdimm , X86 ML , linux-kernel@vger.kernel.org, Ingo Molnar , linux-mm@kvack.org, Andy Lutomirski , Andrew Morton , Ross Zwisler On Mon, Dec 14, 2015 at 10:58:45AM -0700, Ross Zwisler wrote: > With this code if CONFIG_MCE_KERNEL_RECOVERY isn't defined you'll get > a compiler error that the function doesn't have a return statement, > right? I think we need an #else to return NULL, or to have the #ifdef > encompass the whole function definition as it was in Tony's version. Right, correct. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org