[PATCH] include/linux/mmdebug.h: should include linux/bug.h

[PATCH] include/linux/mmdebug.h: should include linux/bug.h

[James Morse]

mmdebug.h uses BUILD_BUG_ON_INVALID(), assuming someone else included
linux/bug.h. Include it ourselves.

This saves build-failures such as:
arch/arm64/include/asm/pgtable.h: In function 'set_pte_at':
arch/arm64/include/asm/pgtable.h:281:3: error: implicit declaration of
function 'BUILD_BUG_ON_INVALID' [-Werror=implicit-function-declaration]
   VM_WARN_ONCE(!pte_young(pte),

Fixes: 02602a18c32d7 ("bug: completely remove code generated by disabled VM_BUG_ON()")
Signed-off-by: James Morse <james.morse@arm.com>
---
 include/linux/mmdebug.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 877ef226f90f..772362adf471 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -1,6 +1,7 @@
 #ifndef LINUX_MM_DEBUG_H
 #define LINUX_MM_DEBUG_H 1
 
+#include <linux/bug.h>
 #include <linux/stringify.h>
 
 struct page;
-- 
2.6.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] include/linux/mmdebug.h: should include linux/bug.h

[James Morse]

Hi Andrew,

Andrew Morton's robot wrote:
> The patch titled
>      Subject: include/linux/mmdebug.h: should include linux/bug.h
> has been added to the -mm tree.  Its filename is
>      include-linux-mmdebugh-should-include-linux-bugh.patch

> The -mm tree is included into linux-next and is updated
> there every 3-4 working days

I'm unsure of your process for fixes - but could this be considered as a
fix for 4.4-rc6?

This problem was exposed by a fix merged for 4.4-rc5, and is currently
breaking the build of arm64 with XEN [0] or the mantis pci driver[1].

Sorry if this wasn't clear from the commit message...


Thanks,

James

[0] https://lkml.org/lkml/2015/12/14/489
[1] https://lkml.org/lkml/2015/12/15/910

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] include/linux/mmdebug.h: should include linux/bug.h

[Andrew Morton]

On Wed, 16 Dec 2015 11:28:45 +0000 James Morse <james.morse@arm.com> wrote:

> Hi Andrew,
> 
> Andrew Morton's robot wrote:
> > The patch titled
> >      Subject: include/linux/mmdebug.h: should include linux/bug.h
> > has been added to the -mm tree.  Its filename is
> >      include-linux-mmdebugh-should-include-linux-bugh.patch
> 
> > The -mm tree is included into linux-next and is updated
> > there every 3-4 working days
> 
> I'm unsure of your process for fixes - but could this be considered as a
> fix for 4.4-rc6?

The process for "wtf did Andrew do with my patch" is to look in
http://ozlabs.org/~akpm/mmots/series (which I update around 5PM PST on
US weekdays) and find the patch.

Today you'll see

#NEXT_PATCHES_START mainline-urgent
proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter.patch
mm-zswap-change-incorrect-strncmp-use-to-strcmp.patch
include-linux-mmdebugh-should-include-linux-bugh.patch

so yup, it's head-of-queue and I'll send it Linuswards probably
tomorrow.  Or maybe today.

> This problem was exposed by a fix merged for 4.4-rc5, and is currently
> breaking the build of arm64 with XEN [0] or the mantis pci driver[1].
> 
> Sorry if this wasn't clear from the commit message...

It helps a lot when commit messages explain the seriousness/impact of
the bug.  But fixes for build errors are so self-explanatory, even I can
understand them ;)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>